Closed KalleOlaviNiemitalo closed 3 years ago
The j2html-1.5.0 upgrade came from https://github.com/jenkinsci/pull-request-monitoring-plugin/pull/104.
I imagine this could have been avoided with automated tests.
The j2html-1.5.0 upgrade came from #104.
I imagine this could have been avoided with automated tests.
Thank you for your support. Yes, that's right. I should do that urgently.
Version report
Jenkins and plugins versions report:
Java is AdoptOpenJDK 25.282-b08 (HotSpot).
Reproduction steps
Results
Expected result:
No errors.
Actual result:
The log shows:
Analysis
In j2html-1.5.0, TagCreator.span(String) returns SpanTag (source). In j2html-1.4.0, TagCreator.span(String) returns ContainerTag (source). This was changed in https://github.com/tipsy/j2html/pull/156.
Versions of j2html in installed plugins:
It seems MonitoringDefaultAction.getPullRequestMetadataTitle tries to call TagCreator.span(String) returning SpanTag as in j2html-1.5.0, which is bundled with pull-request-monitoring, but j2html-1.4.0 was loaded instead. Perhaps j2html-1.4.0 came from font-awesome-api, on which pull-request-monitoring depends.
Please see Dependencies and Class Loading, especially the sections "Initiating vs. defining loaders" and "pluginFirstClassLoader and its discontents".