search

jenkinsci / report-jtreg-plugin

Jenkins plugin to show JCK reports
https://plugins.jenkins.io/report-jtreg/
MIT License
1 stars 13 forks source link

Refactoring - separating classes into modules #1

Closed patrikcerbak closed 12 months ago

patrikcerbak commented 1 year ago

I did a major refactoring to the whole codebase. Created modules for comparator, diff tool, service, lib and the plugin and separated classes to the modules. Comparator and diff is still dependent on the plugin for now, but I will continue with refactoring it, so it is only dependent on the lib module.

judovana commented 1 year ago

It kille dthe CI.... The gihub ci fiels will neeed to adjust.

judovana commented 12 months ago

Looks good to me. Please merge. Do not forget to rebase chartjs-1 branch on top of this new set!!

Its better to do it now, then later, after more compelx changes go in...

patrikcerbak commented 12 months ago

Please merge.

Was this meant to me? I dont have write access to this repo...

Do not forget to rebase chartjs-1 branch on top of this new set!!

Sure!

judovana commented 12 months ago

merged and will rise your privlidges.

judovana commented 12 months ago

Please merge.

Was this meant to me? I dont have write access to this repo...

Do not forget to rebase chartjs-1 branch on top of this new set!!

Sure!

I had attempted to rebase: https://github.com/jenkinsci/report-jtreg-plugin/pull/3 can you try it out and review?