search

jenkinsci / report-jtreg-plugin

Jenkins plugin to show JCK reports
https://plugins.jenkins.io/report-jtreg/
MIT License
1 stars 13 forks source link

Fix for lost build id and name on chart js1 #14

Closed judovana closed 9 months ago

judovana commented 9 months ago

Since the great refactrig, the abilty to click chart in project (in view it worked) was lost, becasue shortenedName was in BUildReportPlugin, where BuildReport was used in reality.

Do not merge. Will push to head, and will rebase the chartjs-1-rebasedToRefactoredReleased24 f on head then.

pls double check, that plugin indeed works, and that diff/comapre was not broken!

judovana commented 9 months ago

So if clicked, they move you to results? And the comaprator still works?

How do yo feels about the patch? When I was wrting it, I had bad feeling, that that was something we already walked through, and were not sucesfull with...

patrikcerbak commented 9 months ago

So if clicked, they move you to results? And the comaprator still works?

Yes clicking takes me to the corresponding results page. Comparator works as intended.

How do yo feels about the patch? When I was wrting it, I had bad feeling, that that was something we already walked through, and were not sucesfull with...

That was mainly for the very problematic Test class, this does look like a lighter change than that

judovana commented 9 months ago

thanx both. release drafted