jenkinsci / report-jtreg-plugin

Jenkins plugin to show JCK reports
https://plugins.jenkins.io/report-jtreg/
MIT License
1 stars 13 forks source link

Added dynamic macros into Jenkins config #20

Closed patrikcerbak closed 5 months ago

patrikcerbak commented 5 months ago

Added dynamic macros into Jenkins config

The main feature. Now, when setting links to the comparator tool in the Jenkins config, you can use macros which will correspond with the config items set in the section below.

So now, when you for example set a way to look for nvr in the Config items section of Jenkins config and you put nvr into the "Name of the item to find" field. You can use the macro %{nvr} in the comparator links section, which will translate into the nvr of the current job and build according to the report page.

Added a check for escaping the directory

I also added a basic check to stop potential nefarious users from trying to escape directory when using the --build-config-find/--job-config-find or the "Config items" setting in Jenkins. It checks with regex whether there is ../ in the path to the file and if so, it throws an exception.

Reworked comparator argument parsing

Till now, the --build-config-find arguments had to declared before using the dynamic argument itself (for example --nvr). Now it doesnt matter, you can use --nvr before declaring --build-config-find changelog.xml:nvr:/build/nvr.

Other