links brainstorming

[judovana]

links from comaprator

The need of liks as in https://github.com/jenkinsci/report-jtreg-plugin/issues/16 grown. With simple comparator, it is easy:

• job:build
  • is easy, job is going to job, build is going to jtreg that build of that job

Later in each cell of table, the X should have to point to that test (based on row)(in jtreg results) of the build (the build) of the job

With diff, it gets more interesting:

• job:build
  • is easy, job is going to job, build is going to jtreg that build of that job

Later in each cell of table, the number, or numbers must provide many links:

• to point to that test (based on row)(in jtreg results) of the build (the build) of the job
• point to comparator with THIS as set-referential
• point to the diff
• or diffs? We know there is
  • clasicl patch
  • side by side view
  • rich-text patch (aka JRD's one)
• and now imagine. diff agaisnt what? referential ? thats why we need that lin to set something as referential. Against any? A lot fo generating....

My only idea how to fulfil that is soe floating tooltip with set of links above each number:(

links in jtreg-results jelly page

Currently each test have exapnd and track link. Expand will need to remain hardcoded. Howevert the (track) would be needed to be changed to dynamic.

Similarly as per-page links are generated, an mechanism to generate per-test links will need to be created. The track will be jsut one of the user-set links. (well documented as example). Other link here should be the call to stack-trace comparator targetted on that single test only

[judovana]

From top of my head

    public void printTable(String[][] table, int rowSize, int columnSize);
    public String generateTableHeaderItem(String mainLine, List<String> otherLines);

Would need quite an extension. Especially if there are supposed to be several numbers, each of its own set of links... Maybe instead if String, a Object of Cell which may contain list of CellItems, where each cell item can have one primary link, and set of pupu links?

[patrikcerbak]

links from comparator of results

Ok, I agree.

links from comparing stack traces

• pointing to that test -- ok, makes sense
• point to comparator with THIS as referential -- ok, should be easy, just setiing set-referential switch
• point to the diff(s) -- I think it can just point to one diff (for example the classic patch) and the users then can change the type of diff with altering some switch. I think this is better than having many different links, but no strong opinion.

Either way, floating tooltip or the details/summary tags with set of links makes sense to me, both will be usable I think.

links in jtreg-results jelly

So as I understand it, you will be able to set the track link in jenkins settings? Similary to the setting there already is? And there will be one more button to compare stack traces of the test?

Cell, CellItems

I'm for this (or similar) approach, since the table generator is now really ugly, this would make it more "prettier".