jenkinsci / rubymetrics-plugin

Ruby metric reports for Jenkins. Rcov, Rails stats, Rails notes and Flog.
https://plugins.jenkins.io/rubyMetrics/
25 stars 28 forks source link

Load source code on demand #14

Closed md5 closed 10 years ago

md5 commented 10 years ago

This PR changes the RcovFileResult class to avoid retaining the source code of every file in the coverage report in memory for every build.

cloudbees-pull-request-builder commented 10 years ago

plugins » rubymetrics-plugin #2 SUCCESS This pull request looks good

jenkinsadmin commented 10 years ago

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

cloudbees-pull-request-builder commented 10 years ago

plugins » rubymetrics-plugin #3 SUCCESS This pull request looks good

cloudbees-pull-request-builder commented 10 years ago

plugins » rubymetrics-plugin #4 SUCCESS This pull request looks good

cloudbees-pull-request-builder commented 10 years ago

plugins » rubymetrics-plugin #5 SUCCESS This pull request looks good

cloudbees-pull-request-builder commented 10 years ago

plugins » rubymetrics-plugin #6 SUCCESS This pull request looks good

md5 commented 10 years ago

@jglick @kohsuke sorry to ping you guys directly, but I didn't have much luck on the Jenkins Developers list: https://groups.google.com/forum/#!topic/jenkinsci-dev/pERxDC9Iaho

Any chance someone could give me commit and release access to let me merge this PR and cut a new release?

jglick commented 10 years ago

Ask the dev list again, someone usually responds, not sure why no one did in this case.

md5 commented 10 years ago

Since I noticed that #8 got merged, I thought I'd rebase this for y'all.

I don't have a running Maven setup on my new laptop, so I haven't tested this, but I'm assuming the tests all still pass.

md5 commented 10 years ago

ping @pkuczynski

cloudbees-pull-request-builder commented 10 years ago

plugins » rubymetrics-plugin #21 SUCCESS This pull request looks good

pkuczynski commented 10 years ago

I will merge it this week. Just let me put my heads around the code and jenkins plugins env...