search

jenkinsci / rubymetrics-plugin

Ruby metric reports for Jenkins. Rcov, Rails stats, Rails notes and Flog.
https://plugins.jenkins.io/rubyMetrics/
25 stars 28 forks source link

enable it to work with older and LTS releases #24

Closed michaelneale closed 9 years ago

michaelneale commented 9 years ago

Shouldn't be any reason why a new NON LTS version is needed.

see: https://github.com/jenkinsci/rubymetrics-plugin/commit/990f7a24dac005c3c40c155698a91f516bc154cd

jenkinsadmin commented 9 years ago

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

recampbell commented 9 years ago

@pkuczynski Ping?

pkuczynski commented 9 years ago

I have not tried this and not really have chance to do that now. I assume you already tried and its safe to merge in?

michaelneale commented 9 years ago

Well I have done it before with others - and I know this plugin can work with older core versions, but I haven't performed a release of this specific plugin. On Mon, 24 Nov 2014 at 4:18 pm Piotr Kuczynski notifications@github.com wrote:

I have not tried this and not really have chance to do that now. I assume you already tried and its safe to merge in?

— Reply to this email directly or view it on GitHub https://github.com/jenkinsci/rubymetrics-plugin/pull/24#issuecomment-64153186 .

pkuczynski commented 9 years ago

I will give it a try and revert in case of trouble :)

michaelneale commented 9 years ago

Cheers. Sometimes the only way eh ;) On Mon, 24 Nov 2014 at 4:20 pm Piotr Kuczynski notifications@github.com wrote:

I will give it a try and revert in case of trouble :)

— Reply to this email directly or view it on GitHub https://github.com/jenkinsci/rubymetrics-plugin/pull/24#issuecomment-64153267 .