search

jenkinsci / rubymetrics-plugin

Ruby metric reports for Jenkins. Rcov, Rails stats, Rails notes and Flog.
https://plugins.jenkins.io/rubyMetrics/
25 stars 28 forks source link

no-test-jar=false #31

Closed jglick closed 7 years ago

jglick commented 7 years ago

Downstream of https://github.com/jenkinsci/plugin-pom/pull/38.

@reviewbybees

ghost commented 7 years ago

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

pkuczynski commented 7 years ago

@jglick seems that the build fails due JavaDoc error. Would you mind having a look?

jglick commented 7 years ago

Seems to pass on JDK 8 but not 7; will adjust CI settings.

abayer commented 7 years ago

@jglick doesn't it need to pass with 7 to do the release?

jglick commented 7 years ago

doesn't it need to pass with 7 to do the release?

Only if you

JAVA_HOME=…/jdk7 mvn release:{prepare,perform}

At any rate I think JDK 8 is the default tool for doing builds.

abayer commented 7 years ago

Ah. I've had some problems with jdk8 targeting 7 but that may just be Groovy weirdness. So :bee:

jglick commented 7 years ago

@reviewbybees done

ghost commented 7 years ago

This pull request has completed our internal processes and we now respectfully request the maintainers of this repository to consider our proposal contained within this pull request for merging.

jglick commented 7 years ago

Needs fix, do not merge.

pkuczynski commented 7 years ago

@jglick OK

jglick commented 7 years ago

Now should be OK.

pkuczynski commented 7 years ago

Merging then...

pkuczynski commented 7 years ago

Should I release new version too?

jglick commented 7 years ago

Well there is no user benefit, I just filed this so that you would not accidentally try to update the parent POM and not notice that you needed to switch the test-jar format.