jenkinsci / sidebar-link-plugin

Jenkins sidebar-link plugin
https://plugins.jenkins.io/sidebar-link/
MIT License
26 stars 43 forks source link

Update Center warns about Sidebar Link upgrade from 2.0.0 to 2.0.1 #37

Closed KalleOlaviNiemitalo closed 2 years ago

KalleOlaviNiemitalo commented 2 years ago

Jenkins and plugins versions report

Environment ```text Jenkins: 2.319.3 OS: Windows Server 2012 R2 - 6.3 --- Office-365-Connector:4.15.2 ace-editor:1.1 analysis-model-api:10.9.1 ansicolor:1.0.1 antisamy-markup-formatter:2.7 apache-httpcomponents-client-4-api:4.5.13-1.0 atlassian-bitbucket-server-integration:3.1.0 authentication-tokens:1.4 authorize-project:1.4.0 azure-ad:191.vfc8019068670 azure-sdk:85.v4817a_b_8a_7124 basic-branch-build-strategies:1.3.2 bitbucket-server-checks:1.0-SNAPSHOT (private-49d94041-kalle) bootstrap4-api:4.6.0-3 bootstrap5-api:5.1.3-4 bouncycastle-api:2.25 branch-api:2.7.0 buildtriggerbadge:2.11 caffeine-api:2.9.2-29.v717aac953ff3 checks-api:1.7.2 cloudbees-bitbucket-branch-source:751.vda_24678a_f781 cloudbees-disk-usage-simple:0.10 cloudbees-folder:6.17 command-launcher:1.6 compress-artifacts:1.10 configuration-as-code:1346.ve8cfa_3473c94 copyartifact:1.46.2 credentials:1074.v60e6c29b_b_44b_ credentials-binding:1.27.1 custom-tools-plugin:0.8 data-tables-api:1.11.3-6 display-url-api:2.3.5 dtkit-api:3.0.0 durable-task:493.v195aefbb0ff2 echarts-api:5.2.2-2 extended-choice-parameter:0.82 extended-read-permission:3.2 fast-track:1.0.0 font-awesome-api:5.15.4-5 forensics-api:1.7.0 git:4.10.3 git-client:3.11.0 git-forensics:1.3.0 git-server:1.10 handlebars:3.0.8 handy-uri-templates-2-api:2.1.8-1.0 hudson-wsclean-plugin:1.0.8 jackson2-api:2.13.1-246.va8a9f3eaf46a javax-activation-api:1.2.0-2 javax-mail-api:1.6.2-5 jaxb:2.3.0.1 jdk-tool:1.0 jira:3.6 job-restrictions:0.8 jquery:1.12.4-1 jquery3-api:3.6.0-2 jsch:0.1.55.2 junit:1.54 lockable-resources:2.14 mailer:408.vd726a_1130320 matrix-auth:3.0.1 matrix-project:1.20 momentjs:1.1.1 mstest:1.0.0 next-build-number:1.8 nunit:0.27 okhttp-api:4.9.3-105.vb96869f8ac3a pipeline-build-step:2.15 pipeline-graph-analysis:188.v3a01e7973f2c pipeline-graph-view:51.v5a693b766483 pipeline-input-step:446.vf27b_0b_83500e pipeline-milestone-step:100.v60a_03cd446e1 pipeline-model-api:1.9.3 pipeline-model-definition:1.9.3 pipeline-model-extensions:1.9.3 pipeline-rest-api:2.21 pipeline-stage-step:291.vf0a8a7aeeb50 pipeline-stage-tags-metadata:1.9.3 pipeline-stage-view:2.21 pipeline-utility-steps:2.12.0 plain-credentials:1.8 plugin-util-api:2.13.0 popper-api:1.16.1-2 popper2-api:2.11.2-1 prism-api:1.25.0-2 resource-disposer:0.17 scm-api:595.vd5a_df5eb_0e39 script-security:1131.v8b_b_5eda_c328e sidebar-link:2.0.0 sidebar-update-notification:1.1.0 snakeyaml-api:1.29.1 ssh-credentials:1.19 sshd:3.1.0 structs:308.v852b473a2b8c timestamper:1.17 token-macro:270.v8c2ce50dc4fc trilead-api:1.0.13 vstestrunner:1.0.8 warnings-ng:9.11.0 windows-slaves:1.0 workflow-aggregator:2.6 workflow-api:1136.v7f5f1759dc16 workflow-basic-steps:2.24 workflow-cps:2648.va9433432b33c workflow-cps-global-lib:552.vd9cc05b8a2e1 workflow-durable-task-step:1121.va_65b_d2701486 workflow-job:1145.v7f2433caa07f workflow-multibranch:706.vd43c65dec013 workflow-scm-step:2.13 workflow-step-api:622.vb_8e7c15b_c95a_ workflow-support:813.vb_d7c3d2984a_0 ws-cleanup:0.40 xunit:3.0.5 ```

What Operating System are you using (both controller, and any agents involved in the problem)?

Windows Server 2012 R2

Reproduction steps

  1. Install Sidebar Link plugin version 2.0.0.
  2. Restart Jenkins controller.
  3. Check for available plugin updates in Update Center.

Expected Results

Sidebar Link 2.0.1 should be listed as available and compatible with the installed version, because 2.0.1 is compatible with 2.0.0 and only incompatible with settings saved by 1.* versions.

Actual Results

Sidebar Link 2.0.1 is listed with this warning:

Warning: The new version of this plugin is marked as incompatible with the installed version. This is usually the case because its behavior changed, or because it uses a different settings format than the installed version. Jobs using this plugin may need to be reconfigured, and/or you may not be able to cleanly revert to the prior version without manually restoring old settings. Consult the plugin release notes for details.

Anything else?

I guess this should say 2.0.0 rather than 2.00.1:

https://github.com/jenkinsci/sidebar-link-plugin/blob/1c9f67f968a8d780f2e1cbbd9e91461a05e9cc17/pom.xml#L19

damianszczepanik commented 2 years ago

This is correct - thanks for reporting this issue