[JENKINS-68250] Fixes PNG help icon usage.

alecharp commented 2 years ago

Fixes #40. Comes with #42 and #41.

Using a recent enough version of Jenkins, the SVG files are already available, along side the PNG files. But, to prepare 2.333 and the PNG removal, we are now defaulting to the SVG help icon.

This won't solve the problem when users are setting the icon link to a PNG file bundled in core.

[x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
[x] Ensure that the pull request title represents the desired changelog entry
[x] Please describe what you did
[x] Link to relevant issues in GitHub or Jira
[x] Link to relevant pull requests, esp. upstream and downstream changes
[ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

alecharp commented 2 years ago

@damianszczepanik do you think this is now good enough to be merged and have a release of the plugin with this content?

NotMyFault commented 2 years ago

Thanks for merging @damianszczepanik, do you think you can cut a release anytime soon to publish the changes?

damianszczepanik commented 2 years ago

With I could but when trying to build locally I get following:

INFO] --- maven-hpi-plugin:3.27:insert-test (default-insert-test) @ sidebar-link --- DEBUG] Configuring mojo org.jenkins-ci.tools:maven-hpi-plugin:3.27:insert-test from plugin realm ClassRealm[extension>org.jenkins-ci.tools:maven-hpi- lugin:3.27, parent: jdk.internal.loader.ClassLoaders$AppClassLoader@5b37e0d2] DEBUG] Configuring mojo 'org.jenkins-ci.tools:maven-hpi-plugin:3.27:insert-test' with basic configurator --> DEBUG] (f) disabledTestInjection = false DEBUG] (f) injectedTestName = InjectedTest DEBUG] (f) jenkinsTestHarnessId = org.jenkins-ci.main:jenkins-test-harness DEBUG] (f) project = MavenProject: org.jenkins-ci.plugins:sidebar-link:2.2.0 @ D:\git\sidebar-link-plugin\pom.xml DEBUG] (f) requirePI = true DEBUG] (f) session = org.apache.maven.execution.MavenSession@120350eb DEBUG] -- end configuration -- INFO] ------------------------------------------------------------------------ INFO] BUILD FAILURE INFO] ------------------------------------------------------------------------ INFO] Total time: 17.052 s INFO] Finished at: 2022-04-21T23:27:33+02:00 INFO] ------------------------------------------------------------------------ ERROR] Failed to execute goal org.jenkins-ci.tools:maven-hpi-plugin:3.27:insert-test (default-insert-test) on project sidebar-link: Failed to create njected tests: sidebar-link-plugin\target\generated-test-sources\injected\InjectedTest.java: Parametr is invalid. -> [Help 1] rg.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.jenkins-ci.tools:maven-hpi-plugin:3.27:insert-test (default-insert- est) on project sidebar-link: Failed to create injected tests at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:215)

It was working fine before 1c20c7611e44d1868aa05ec6d0689eea05aa1a18 but now even reverting this commit does not solve the problem

damianszczepanik commented 2 years ago

@alecharp any idea why your changes stopped me from local testing ?

alecharp commented 2 years ago

(sorry, no access to my laptop right now, but..) I just tried on a fresh checkout of the PR, and didn't get any error on mvn verify

Which version of Java and Maven are you using on your side? Could you try to clean the project?

alecharp commented 2 years ago

I just tried again locally and I still have no problem. CI seems to be fine as well (see checks on https://github.com/jenkinsci/sidebar-link-plugin/commit/f3f8c335ca94f0fbff8e8baa032cf8c0aac87d6f)

damianszczepanik commented 2 years ago

Published

jenkinsci / sidebar-link-plugin

[JENKINS-68250] Fixes PNG help icon usage. #43