search

jenkinsci / sidebar-link-plugin

Jenkins sidebar-link plugin
https://plugins.jenkins.io/sidebar-link/
MIT License
26 stars 43 forks source link

use https instead of git #63

Open programbeginnerTW opened 1 year ago

programbeginnerTW commented 1 year ago

use https protocol instead of git protocol because Github is deprecating git protocol

### Submitter checklist
- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
damianszczepanik commented 1 year ago

Share the announcement about it

programbeginnerTW commented 1 year ago

@damianszczepanik I've created a new post here !

Greetings!

damianszczepanik commented 1 year ago

Recently I had problems because of invalid protocol https://github.com/jenkinsci/sidebar-link-plugin/pull/63/files - the problem occurs only during release goal but not at the compile/test/verification stage

MarkEWaite commented 1 year ago

Recently I had problems because of invalid protocol https://github.com/jenkinsci/sidebar-link-plugin/pull/63/files - the problem occurs only during release goal but not at the compile/test/verification stage

Thanks for the clarification. The plugin archetype uses https, so no objections from me that this plugin uses https. When I generated an empty plugin from the archetype, the scm section looked like this:

    <connection>scm:git:https://github.com/${gitHubRepo}</connection>
    <developerConnection>scm:git:https://github.com/${gitHubRepo}</developerConnection>
    <tag>${scmTag}</tag>
    <url>https://github.com/${gitHubRepo}</url>

Anything that brings plugins closer to the syntax used by the plugin archetype is great for me.

damianszczepanik commented 1 year ago

Since this can be tested only during the release process I will accept only configuration that was proven during the release, eg https://github.com/damianszczepanik/maven-cucumber-reporting/blob/master/pom.xml