jenkinsci / simple-theme-plugin

A simple theme plugin for Jenkins
https://plugins.jenkins.io/simple-theme-plugin
MIT License
56 stars 47 forks source link

[JENKINS-50346] Cannot style build-monitor since 0.4 #107

Open TobiX opened 6 years ago

TobiX commented 6 years ago

I added a "workaround" to not style build-monitor pages at all (https://github.com/jenkinsci/simple-theme-plugin/commit/cc68d1a82909f6e1fa1f9b4ec2a85b05d738383b) since all styles on GitHub are not aware of that plugin and therefore break its design.

Unfortunatly some users want to style the build-monitor and now aren't able anymore. This should therefore be user-configurable. Maybe tackle support for styling BlueOcean in a similar way (opt-in, see JENKINS-49081)


Originally reported by tgr, imported from: Cannot style build-monitor since 0.4
  • assignee: tgr
  • status: Open
  • priority: Minor
  • resolution: Unresolved
  • imported: 2022-10-30
TobiX commented 6 years ago

taree7734:

I see a possible solutions here:

In jenkins-config add a list for ignored classes. These could be evaluated in SimpleThemeDecorator.java
Replace

if (o.getClass().getName().startsWith("com.smartcodeltd.jenkinsci.plugins.buildmonitor")) {
    return false;
}

with something like

for (String e : list) {
    if (o.getClass().getName().contains(e)) {
return false;
    }.
}

With that solution it would be fully user-configurable, which pages (/plugins) are excluded.