favicon generates inline js which is not CSP compliant. This changes it so the url is provided via a data-url attribute of the script.
Also simplifies a bit the javascript and uses modern syntax.
Testing done
Manual testing that favicon still works
Verified with CSP plugin that there are no errors related to favicon
Submitter checklist
[x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
[x] Ensure that the pull request title represents the desired changelog entry
[x] Please describe what you did
[ ] Link to relevant issues in GitHub or Jira
[ ] Link to relevant pull requests, esp. upstream and downstream changes
[ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue
TobiX
commented
2 months ago
favicon generates inline js which is not CSP compliant. This changes it so the url is provided via a data-url attribute of the script. Also simplifies a bit the javascript and uses modern syntax.
Testing done
Manual testing that favicon still works Verified with CSP plugin that there are no errors related to favicon
Submitter checklist