search

jenkinsci / stashnotifier-plugin

A Jenkins Plugin to notify Atlassian Stash|Bitbucket of build results
https://plugins.jenkins.io/stashNotifier/
Other
163 stars 136 forks source link

Bitbucket 7.15 RestAPI update #290

Open swaragade opened 2 years ago

swaragade commented 2 years ago

What feature do you want to see added?

StashNotifier plugin (v1.25) uses a Bitbucket API here for sending the build notifications. This API has been deprecated by the Bitbucket. Please add support for new BitBucket Notification API

Upstream changes

No response

swaragade commented 2 years ago

@scaytrase kindly check

scaytrase commented 2 years ago

@swaragade currently I have neither bitbucket instance nor active jenkins installations, so It would be hard to implement this feature by myself. But any PR is welcome here

offa commented 2 years ago

@swaragade are you sure? The endpoint is still listed without any deprecation notice: https://developer.atlassian.com/server/bitbucket/how-tos/updating-build-status-for-commits/

roman-mibex-2 commented 1 year ago

This API is deprecated. However, it wasn't marked properly. https://jira.atlassian.com/browse/BSERV-13381 as such.

I got marked properly as deprecated in 8.3: https://developer.atlassian.com/server/bitbucket/rest/v803/api-group-build-status/#api-build-status-latest-commits-commitid-get

roman-mibex-2 commented 1 year ago

The new API requires the projectKey and repoSlug info. This isn't present in the plugin as it is designed now. The projectKey can be supplied optionally.

So, using the new API would require some changes in the design or usage. That would need way more though and time than I can offer at this point in time.

brucewilsn commented 3 months ago

Updating to the new API would be more than just nice at this point. The old API is partly broken. Bitbucket will show the build status next to a commit. But even if the source branch tip shows a successful build, it will not allow merging a pull request (if the target branch is configured to require a successful build.)