Closed sghill closed 11 months ago
@scaytrase I think the build may only run with the Jenkinsfile on the target branch(?).
Java 11 is required and the included Jenkinsfile configuration is recommended starting with parent version 4.52.
@scaytrase I think the build may only run with the Jenkinsfile on the target branch(?).
Jenkinsfile changes require write access, otherwise they wont apply.
@scaytrase based on offa's comment (thanks!) I've limited the scope of this PR to the latest versions that worked on Java 8 to keep the build green.
@scaytrase would you be interested in adding additional maintainers for this plugin?
@sghill I'd like to, since I'm not using Jenkins for many years for now (but still like it). But I have no idea how to grand release permissions to maintainers. I can give only repo permissions here
@scaytrase I'm happy to help maintain. From Managing plugin permissions it sounds like there are two parts -
stashNotifier Developers
team on GitHubMy goals for maintenance would be:
For anything major happy to open a PR and leave it open for review/discussion for a week or so.
Adding me to stashNotifier Developers team on GitHub
I have no permissions even for this one.
I can submit a PR here adding myself if you'd like?
I'd be happy if you can drive the whole process of maintenance sharing since I don't really know all the internal kitchen for Jenkisn development. Tag me wherever one need my approve for this, I'll come
Requested deploy permissions in https://github.com/jenkins-infra/repository-permissions-updater/pull/3481
I've given you permissions but rolled back since it says u've already given admin via team mebmership. thanks a lot!
Thanks @scaytrase!
Upgrade POM parent and
jenkins.version
to last versions that support Java 8. Builds are enabled for Java 11 and 17. Goal is to keep the build green and follow up with a subsequent PR to modernize to current recommended versions.This has been done by the OpenRewrite recipes at sghill/rewrite-jenkins.
Testing done
Ran
mvn clean verify
.Fixes #337 Fixes #327 Related to #326 Fixes #322