jenkinsci / stashnotifier-plugin

A Jenkins Plugin to notify Atlassian Stash|Bitbucket of build results
https://plugins.jenkins.io/stashNotifier/
Other
165 stars 143 forks source link

Modernize to latest versions supported by Java 8 #340

Closed sghill closed 11 months ago

sghill commented 1 year ago

Upgrade POM parent and jenkins.version to last versions that support Java 8. Builds are enabled for Java 11 and 17. Goal is to keep the build green and follow up with a subsequent PR to modernize to current recommended versions.

This has been done by the OpenRewrite recipes at sghill/rewrite-jenkins.

Testing done

Ran mvn clean verify.

### Submitter checklist
- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [x] Link to relevant issues in GitHub or Jira (none)
- [x] Link to relevant pull requests, esp. upstream and downstream changes
- [x] Ensure you have provided tests - that demonstrates feature works or fixes the issue

Fixes #337 Fixes #327 Related to #326 Fixes #322

sghill commented 1 year ago

@scaytrase I think the build may only run with the Jenkinsfile on the target branch(?).

Java 11 is required and the included Jenkinsfile configuration is recommended starting with parent version 4.52.

offa commented 11 months ago

@scaytrase I think the build may only run with the Jenkinsfile on the target branch(?).

Jenkinsfile changes require write access, otherwise they wont apply.

sghill commented 11 months ago

@scaytrase based on offa's comment (thanks!) I've limited the scope of this PR to the latest versions that worked on Java 8 to keep the build green.

sghill commented 11 months ago

@scaytrase would you be interested in adding additional maintainers for this plugin?

scaytrase commented 11 months ago

@sghill I'd like to, since I'm not using Jenkins for many years for now (but still like it). But I have no idea how to grand release permissions to maintainers. I can give only repo permissions here

sghill commented 11 months ago

@scaytrase I'm happy to help maintain. From Managing plugin permissions it sounds like there are two parts -

  1. Adding me to stashNotifier Developers team on GitHub
  2. Adding release permissions through repository-permissions-updater. I can submit a PR here adding myself if you'd like?

My goals for maintenance would be:

  1. Adopting automated plugin release to make maintenance easier. I've had a good CD experience on commons-text-api-plugin (enabled in cc850d17).
  2. Re-baselining every quarter to the minimum recommended Jenkins version with an automated PR like this one
  3. Staying current on tooling, which usually requires fixing SpotBugs issues and deprecations
  4. Minor operator improvements (additional logging for example)

For anything major happy to open a PR and leave it open for review/discussion for a week or so.

scaytrase commented 11 months ago

Adding me to stashNotifier Developers team on GitHub

I have no permissions even for this one.

I can submit a PR here adding myself if you'd like?

I'd be happy if you can drive the whole process of maintenance sharing since I don't really know all the internal kitchen for Jenkisn development. Tag me wherever one need my approve for this, I'll come

sghill commented 11 months ago

Requested deploy permissions in https://github.com/jenkins-infra/repository-permissions-updater/pull/3481

scaytrase commented 11 months ago

I've given you permissions but rolled back since it says u've already given admin via team mebmership. thanks a lot!

sghill commented 11 months ago

Thanks @scaytrase!