search

jenkinsci / unity3d-plugin

Jenkins Unity3d plugin
https://plugins.jenkins.io/unity3d-plugin/
MIT License
96 stars 54 forks source link

update parent pom and necessary modifications for compatibility #23

Closed BobDu closed 5 months ago

BobDu commented 6 months ago

Update parent pom and make the necessary modifications for compatibility. And manual run test in unity 2022 lts version.

Testing done

### Submitter checklist
- [ ] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [ ] Ensure that the pull request title represents the desired changelog entry
- [ ] Please describe what you did
- [ ] Link to relevant issues in GitHub or Jira
- [ ] Link to relevant pull requests, esp. upstream and downstream changes
- [ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue
BobDu commented 6 months ago

@lacostej Sorry to bother you

I see you not continuing use this plugin in https://forum.unity.com/threads/automating-builds-with-jenkins.319169/

Would you be interested in continuing to maintain this plugin?

If needed, I am willing to join the team of unity3d plugin maintainers to continue maintaining this plugin.

BobDu commented 5 months ago

ping @lsegal

I would like to take over the maintenance of this plugin following this process https://www.jenkins.io/doc/developer/plugin-governance/adopt-a-plugin/

Hope to get your feedback. Thanks.

basil commented 5 months ago

Would also be nice to incrementalify the plugin and enable Dependabot.

BobDu commented 5 months ago

@basil thanks for your guidance I will further improve it in subsequent PRs

There are also some things that are bothering me and I would like your advice. I hope to enable CI system for this plugin.

But currently, when running unit tests, you need to have a unity environment on your machine. So making this plugin more difficult to enable CI systems. Do you have any suggestions or know of other plugins that have similar problems and how they solved them?

basil commented 5 months ago

I think (?) if you run the build on a full VM (i.e., buildPlugin(useContainerAgent: false) that you can install any packages you want with sudo apt install […]. If not then you should be able to file a ticket at https://github.com/jenkins-infra/helpdesk for guidance with our container / VM images.