Closed butaca closed 11 years ago
Jenkins » unity3d-plugin #9 SUCCESS This pull request looks good (what's this?)
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests
Unit test please ! ;)
What should I have unit tested? That the command line remained the same? Come on. That's overkill. You can't test every possible thing. In fact, the existing units tests cover too little terrain. Please be coherent.
And it would be nice if you are a bit polite.
I'm just trying to collaborate and not willing to interact with people with bad manners. I'm done here.
— Sent from Mailbox for iPhone
On Fri, Sep 27, 2013 at 8:45 AM, Jerome Lacoste notifications@github.com wrote:
Unit test please ! ;)
Reply to this email directly or view it on GitHub: https://github.com/jenkinsci/unity3d-plugin/pull/4#issuecomment-25239455
Hey sorry that you take things like that! I didn't mean to make you think this was bad. I really appreciate your contributions!
BTW, I will release 0.5 with that fix right away.
Fixed a bug that caused the command line to be overwritten by actual build params if used.