search

jenkinsci / violation-comments-to-gitlab-plugin

Comments GitLab merge requests with static code analyzer findings.
https://plugins.jenkins.io/violation-comments-to-gitlab
MIT License
20 stars 4 forks source link

Clarify that credentials have to be "secret text" credentials #21

Open ite-klass opened 5 years ago

ite-klass commented 5 years ago

The configuration does not make clear that a secret text credential has to be used. Adding a descriptive text or expandable help text would be helpful.

This is especially confusing when the GitLab plugin is installed as well, which adds a credential category for personal API tokens. Given that this plugins setting is labeled as "personal API token" as well, it implies that that credential category should be used, but then fails to identify it. (Adding the credentials from the Add button and it then simply not appearing as a selectable option is quite confusing.)

tomasbjerre commented 5 years ago

I guess you saw this exception when fiddling with this? No credentials found!

It should probably be changed to state that a secret text credential could not be found.

ite-klass commented 5 years ago

I did not see an exception. I did not check server logs though.

I simply saw no credentials in the credentials selection dropdown.