Prettify step generator and deprecate password

jenkinsci / violation-comments-to-stash-plugin

Comments Bitbucket Server (or Stash) pull requests with static code analyzer findings.

https://plugins.jenkins.io/violation-comments-to-stash

MIT License

43 stars 16 forks source link

Prettify step generator and deprecate password #45

Closed jetersen closed 6 years ago

jetersen commented 6 years ago

Deprecating username and password.
Created descriptors and jelly configs as needed.
Simplified mostly 👍

jetersen commented 6 years ago

@tomasbjerre Should be good to go once #46 is merged 👍

jetersen commented 6 years ago

I would argue we should bump Jenkins Level up to 2.60.3 at least to get Java 8 target 👍 http://stats.jenkins.io/pluginversions/violation-comments-to-stash.html

To replace some of that Guava crust 🙊

tomasbjerre commented 6 years ago

This is great stuff! I will have a closer look later.

For now, do an mvn package to have the code formatted with Google Java Format. There are a couple of minor formatting issues in ViolationsToBitbucketServerGlobalConfiguration and ViolationsToBitbucketServerConfig.