jenkinsci / violation-comments-to-stash-plugin

Comments Bitbucket Server (or Stash) pull requests with static code analyzer findings.
https://plugins.jenkins.io/violation-comments-to-stash
MIT License
43 stars 16 forks source link

Plugin causes job hangs #48

Closed vzabawski closed 6 years ago

vzabawski commented 6 years ago

I have a job that generates lint-compatible xml and violation comments plugin reports those violations to Bitbucket. Sometimes job hangs on "Report violations steps". Console output stops at

Archiving artifacts
---
--- Jenkins Violation Comments to Bitbucket Server ---
---
bitbucketServerUrl: https://bitbucket.example.com
projectKey: OI
repoSlug: reponame
pullRequestId: 2079
usernamePasswordCredentialsId: true
username: false
password: false
createSingleFileComments: true
createCommentWithAllSingleFileComments: false
commentOnlyChangedContent: false
commentOnlyChangedContentContext: 0
minSeverity: INFO
keepOldComments: false
LINT with pattern .*\\report.xml
Using username and password from credentials
Pull request: 2079
Workspace: F:\jenkins\jobs\SelfServiceHostConfigValidator\workspace
Found 21 violations from ViolationConfig [pattern=.*\\report.xml, reporter=LINT, parser=LINT].
PR: TPP/reponame/2079 on https://bitbucket.example.com

Environment: Windows Server 2012 R2 Java: 1.8.0.151 I've spotted such behavior on Jenkins 2.73.3, 2.89.2 Plugin version: 1.63-1.65 I've just updated to 1.66 but I'm not sure, if this will help. Thread dump: here

If you need any further information feel free to ask me.

tomasbjerre commented 6 years ago

Probably just needs a timeout here: https://github.com/tomasbjerre/violation-comments-to-bitbucket-server-lib/blob/1.43/src/main/java/se/bjurr/violations/comments/bitbucketserver/lib/client/BitbucketServerInvoker.java#L37

Should be an easy fix.

vzabawski commented 6 years ago

Are you planning to include this fix in the next release?

tomasbjerre commented 6 years ago

Yes, I'll probably have time to fix it later today =)

tomasbjerre commented 6 years ago

Should be fixed in 1.67.

vzabawski commented 6 years ago

Thanks a lot!