search

jenkinsci / zulip-plugin

Jenkins plugin for Zulip notifications of build status
https://zulip.com/integrations/doc/jenkins
MIT License
14 stars 22 forks source link

Add personal notify feature #22

Closed volo-zyko closed 3 years ago

volo-zyko commented 5 years ago

With this code ZulipNotifier along with messages to some stream/topic will send personal notifications to code committers.

I didn't update README.markdown yet but I surely do it once you decide that the changes are worthy.

Another thing. zulipPersonalSend similar to zulipSend can be useful and I can add it too.

volo-zyko commented 5 years ago

CI has failed with some unclear messages which, it seems, are not related to my changes.

Windows: Remote call on JNLP4-connect connection from 52.191.116.151/52.191.116.151:49187 failed

Linux: java.lang.OutOfMemoryError: Java heap space

butchyyyy commented 5 years ago

Hi @volo-zyko , thank you for the contribution! I'm on my vacation now so I only took a brief look. I'll do a thorough review next week. In general I like the possibility to nag people who broke the build via PM :)

The failing build is probably just something in the CI infrastructure so don't worry about it now. I'll run the build / tests as a part of the review.

volo-zyko commented 3 years ago

@butchyyyy, I don't understand what's wrong with my change and why it's not accepted. Is the idea itself totally wrong, or there are problems with the implementation. I fixed all the issues more than a year ago but there is no feedback. I don't understand how this works.

volo-zyko commented 3 years ago

It looks like the maintainer is not interested in this feature. So, I'm dropping it.