search

jenkinsci / zulip-plugin

Jenkins plugin for Zulip notifications of build status
https://zulip.com/integrations/doc/jenkins
MIT License
14 stars 22 forks source link

Failed builds should use :cross_mark: rather than :x: #26

Closed tbroyer closed 4 years ago

tbroyer commented 4 years ago

With Zulip's "Google modern" emoji theme (which I think is the default), in Zulip 3.1, the :x: displays as a cross in a green box (seems to match Android 10: https://emojipedia.org/google/android-10.0/cross-mark-button/, Android 9 and Android 11 had/have a red cross in a black-bordered white box, looking like what was displayed in Zulip 2.x)

I'd suggest using :cross_mark: instead, which is more consistently displayed in red: https://emojipedia.org/cross-mark/

Moreover, a successful build uses :check_mark:, which is not in a box: https://emojipedia.org/check-mark/ so it would be more consistent.

timabbott commented 4 years ago

@tbroyer thanks for the feedback! What integration are you seeing us using :x: with? git grep ':x:' returns no results in our main codebase.

timabbott commented 4 years ago

Oh, sorry, I missed the repository was the Jenkins plugin. Sorry for the confusion! Yes, this sounds like a good change.

timabbott commented 4 years ago

Want to submit a PR? I imagine @butchyyyy will review/merge and then get a release to happen.

butchyyyy commented 4 years ago

Just released version 1.2.1 that replaces the emoji for failed builds as proposed by @tbroyer . Should be available via Jenkins update center in few hours.

Thanks for reporting!

tbroyer commented 4 years ago

Thank you!

On a side note, here in France, I reported the issue at 6pm :clock630: just after I saw my build failure notification in our Zulip instance at work, it was fixed and released by midnight :clock12: :rocket:, and a coworker installed it this morning even before I started working :clock830: :tada: Fixed overnight!