jenkinsci / zulip-plugin

Jenkins plugin for Zulip notifications of build status
https://zulip.com/integrations/doc/jenkins
MIT License
14 stars 22 forks source link

fix: java 17 authentication #42

Closed butchyyyy closed 1 year ago

butchyyyy commented 1 year ago

In Java 17, the authenticator is invoked with SERVER requestor even when the initial request is performed and even tho we provide the preemptive authorization via header.

Since our authenticator implementaiton did not provide credentials for SERVER requestor, only for PROXY, the message sending would crash with java.io.IOException: No credentials provided error.

Fixes #40

Testing done

### Submitter checklist
- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [x] Link to relevant issues in GitHub or Jira
- [x] Link to relevant pull requests, esp. upstream and downstream changes
- [x] Ensure you have provided tests - that demonstrates feature works or fixes the issue