Add ability to NOT fail the build if Zulip is down

jenkinsci / zulip-plugin

Jenkins plugin for Zulip notifications of build status

https://zulip.com/integrations/doc/jenkins

MIT License

14 stars 22 forks source link

Add ability to NOT fail the build if Zulip is down #5

Closed wolfen351 closed 5 years ago

wolfen351 commented 8 years ago

My zulip server is on a non UPS protected machine, so every now and again the zulip instance goes down. I want to be able to "ignore" failure to post to zulip - i.e. write some warning in the console output of the log but not actually fail the build

timabbott commented 8 years ago

Hmm yeah that would be a great improvement.

butchyyyy commented 5 years ago

The build won't fail if plugin receives a non 200 response from Zulip, but will fail if Zulip server can't be reached (IOException). I agree that this is a bug and both cases should be handled same = log the error, but don't fail the build. I'll submit a PR with the fix soon. In the future we could add a "Fail build when message to Zulip fails to send" check box, but for now i would not bloat the configuration unless someone specifically asks for it.