weijia-cheng commented 1 year ago

Lint

[x] Alt-text and title of illustration-3 need to match. I think the 3/4 (as opposed to the fraction version, which was ontroduced by typogrify) formatting is more correct.
[x] You should give yourself the wat role in content.opf.

Semantics

[x] chapter-13: for a chapter of her book which is headed <i epub:type="se:name.publication.book">Noel</i> I don˚t think it makes sense to give “Noel” the book semantics when it’s just a chapter heading. Replace the italics with quotation marks (can be a non-editorial commit).
[x] chapter-14: The emphasis on “Réaumur” can be dropped. It looks like it got italicized as a non-English word originally, and it doesn’t parse as emphasis. For comparison I don’t think we would write fifteen degrees of frost <em>Celsius</em>, for example.
[x] chapter-14: Emphasis on “crescendo” can be dropped.
[x] chapter-4: You gave the poem semantic to “Two paradises ’twere in one to live in Paradise alone,” but that looks more like z3998:verse since it is just a verse fragment and not a complete poem. Make sure to update the CSS to add z3998:verse too.
[x] chapter-9: The “Will Satan mich verschlingen” passage needs German semantics (see 8.2.9.6). I also looked this up and it appears to be a hymn, in which case you should use z3998:hymn specifically (and you can update the CSS to include hymn along with poem and verse).

[x] pfenning can be modernized to pfennig in an editorial commit (and then the italics can be removed in a subsequence non-editorial commit because that’s found in Merriam-Webster).

[x] chapter-9: “Auge um Auge, Zabn um Zahn” should have quotation marks around it if it’s a quote.
[x] chapter-7: You are missing a space before (a great local celebrity).
[x] æ ligature should be expanded into ae.

[x] Wiki link for von Arnim should be https://en.wikipedia.org/wiki/Elizabeth_von_Arnim (the current link capitalizes the V which causes a redirect). The colophon should be updated as well.

[x] cd7c1fccedc16b733a9af6eddd2cd0a51b73db6c: This shouldn’t be an editorial commit since it’s just a manual semantic addition without any significant change from the original text. This can be done in a relatively simple rebase. If you’re not familiar with how to rename commit messages in a rebase, let’s address the other issues first and I can give you more detailed instructions on how to do this.

jennfrye commented 1 year ago

Done! (I think.)

I am not sure if I should have used the [Editorial] tag for [Editorial] Removed emphasis of now-English words. I now am pretty comfortable rebasing so can fix this if needed.
I think I'd already given myself the wat role in content.opf, so I didn't change anything there. I hope I'm understanding this correctly.
Instead of expanding the æ in "ipomæa," I changed it to "ipomoea" as this is apparently the alternate spelling.

Thank you for your help!

weijia-cheng commented 1 year ago

[x] The "Removed emphasis of now-English words" commit can be rebased to be non-editorial.
[x] æ > ae should be rebased to be an editorial commit.
[x] I see what the wat problem is. All of the instances of se:role in content.opf need to be changed to simply role. We had to use se:role for a while to conform to an older version of the EPUB spec, but that is not an issue now.
[x] You still need to remove the italics around "pfenning"

jennfrye commented 1 year ago

Finished! Thank you for your patience and for explaining everything.