search

jennielees / leagueoflegends-python

Python API wrapper for Riot's official League of Legends API
28 stars 11 forks source link

Getting errors when using summoner related calls #2

Closed LJamesHu closed 10 years ago

LJamesHu commented 10 years ago

I believe due to the latest updates from Riot on the API, some of these calls don't work anymore. Any potential updates here and on pip?

jennielees commented 10 years ago

I'm busy with work for the next few days as it's PyData this weekend :-) However, happy to receive pull requests!

On Thursday, 1 May 2014, LJamesHu notifications@github.com wrote:

I believe due to the latest updates from Riot on the API, some of these calls don't work anymore. Any potential updates here and on pip?

— Reply to this email directly or view it on GitHubhttps://github.com/jennielees/leagueoflegends-python/issues/2 .

LJamesHu commented 10 years ago

Alright. I have wanted to try my hand at contributing to a project on git.

From what I can see, they vastly changed the API from when this was started. They added a entirely new APIs and changed up existing ones significantly.

LJamesHu commented 10 years ago

I'm interested in updating the API but since you haven't accepted the last pull request I sent in or commented on any of my posts since, I'm just wondering if I should work on it or look at using/contributing to a different repository. I like how it uses the leagueoflegends package name but its so un-updated I think all or most of the API references are probably broken.

jennielees commented 10 years ago

Updated to v1.4 to sync with Summoner API version and uploaded to PyPI. You are always welcome to continue working in a fork and if the fork gets way ahead of me, I can release the namespace if necessary!