jenniferabowd / jest_webpack_example

MIT License
63 stars 25 forks source link

Update React 16 → 18 #13

Closed brandonmcconnell closed 1 year ago

brandonmcconnell commented 1 year ago

Resolves #7

Updated React from v16 to v18.

I did see the warnings about peer dependencies you mentioned, @jenniferabowd, however, I saw those both when upgrading to v17 and then to v18.

Although I saw these warnings, the vulnerability counts remained the same, and the project appears to function the same as it did before. Is this okay for this PR, or is there more work required for this issue?

brandonmcconnell commented 1 year ago

@jenniferabowd Never mind! I managed to take care of those peer dependency warnings as well by updating…

So this would be the solution to update everything this PR accomplishes in a single command:

npm install react@latest react-dom@latest react-test-renderer@latest react-redux@latest redux@latest

I just split it into 2 different commits 🙂

jenniferabowd commented 1 year ago

@brandonmcconnell if you are doing this for Hacktoberfest, feel free to split up the PR since it is addressing several issues.

brandonmcconnell commented 1 year ago

@jenniferabowd Sure, I'll do that. Thanks!

jenniferabowd commented 1 year ago

Oops! I already merged it! However, I see you assigned yourself a few things.

brandonmcconnell commented 1 year ago

@jenniferabowd No worries!