search

jenniferabowd / jest_webpack_example

MIT License
63 stars 25 forks source link

Updated Webpack #14

Closed NazimFilzer closed 1 year ago

NazimFilzer commented 1 year ago

Hey have Updated it.. If any more issues please lemme Know🙂

jenniferabowd commented 1 year ago

Hi, I'm sorry to do this, but this isn't what I had in mind. I'm pretty sure updating Webpack is going to break a bunch of stuff. Did you verify this isn't breaking on npm start or npm test? Also, I think to make this change, there should be two folders, one folder for Webpack 5 and the other for Webpack 2. However, if updating Webpack isn't breaking things, then that isn't needed.

NazimFilzer commented 1 year ago

Ohh Sorry... Had no idea about that... The code is Breaking n I have no idea 😓. I will be closing this PR... Sorry for wasting ur time

jenniferabowd commented 1 year ago

No worries! Don't feel bad! You gave it a try! Sorry for not being more clear on the issue ticket! Do you want to work on doing this? I suspect this will relatively be a heavy lift.

NazimFilzer commented 1 year ago

Ya.. I am more of a Backend Dev and haven't worked with this before.. So I wont be continuing

jenniferabowd commented 1 year ago

No worries! You gave it a try!