jenniferabowd / jest_webpack_example

MIT License
63 stars 25 forks source link

feat: Implemented hot reloading #20 #22

Closed Muhammad-Shahid-Jamal closed 1 year ago

Muhammad-Shahid-Jamal commented 1 year ago
Muhammad-Shahid-Jamal commented 1 year ago

@jenniferabowd kindly review it thanks

jenniferabowd commented 1 year ago

@Muhammad-Shahid-Jamal yes. I'm working right now, but will check it out once I have some time tonight.

jenniferabowd commented 1 year ago

Hi, unfortunately running commands concurrently is not hot reloading. Hot reloading refreshes the page to show the latest changes, but concurrently only allows you to run two commands at the same time. Would you mind implementing hot reloading?

These links will be helpful for adding in hot reloading: Webpack Hot Module Replacement gaearon/react-hot-loader

Muhammad-Shahid-Jamal commented 1 year ago

Hi, unfortunately running commands concurrently is not hot reloading. Hot reloading refreshes the page to show the latest changes, but concurrently only allows you to run two commands at the same time. Would you mind implementing hot reloading?

These links will be helpful for adding in hot reloading: Webpack Hot Module Replacement gaearon/react-hot-loader

Yeh sure I will try it push that code as well

jenniferabowd commented 1 year ago

Hi I realized this completes the task for https://github.com/jenniferabowd/jest_webpack_example/issues/21, so I'll merge this in, assign that ticket to you, and close it. Do you still want to the hot reloading one too?

Muhammad-Shahid-Jamal commented 1 year ago

Hi I realized this completes the task for #21, so I'll merge this in, assign that ticket to you, and close it. Do you still want to the hot reloading one too?

Yeh sure i wanna try it