We could pass more of our objects to the constructors of other modules.
For example, in our dawn.js, we are doing this:
var decoratedEngine = new DecoratedEngine();
var eventController = new EventController();
var cellRepository = new CellRepository();
var animator = new Animator();
eventController.register(decoratedEngine.matterEngine(), 'afterUpdate', animator, cellRepository);
but it might be better if we could do this instead:
var decoratedEngine = new DecoratedEngine();
var eventController = new EventController(decoratedEngine.matterEngine());
var cellRepository = new CellRepository();
var animator = new Animator(cellRepository);
eventController.register('afterUpdate', animator);
In other words:
the instance of Animator could have a cellRepository.
the instance of EventController could have an engine.
That way we don't have to pass these objects in every time we call methods. See how the eventController.register method now only needs two arguments - an event string and a listener/handler/operator. Instead of also passing in an engine every time we register a listener (I've started calling them listeners now I'm afraid). A similar simplification is achieved by having the animator have its own cellRepository, instead of passing that as an argument.
A similar pattern could be followed for the cellFactory stuff. I.e. cellFactory could have a cellRepository. This would have the same benefit if we use our eventController to register a listener for collisions.
I think we we were concerned that we'd have to update each object's cellRepository if we do things this way (I know I was). But actually, this is why we pass objects in, instead of static arrays - so that these objects are updated across the entire app.
We could pass more of our objects to the constructors of other modules.
For example, in our
dawn.js, we are doing this:but it might be better if we could do this instead:
In other words:
Animatorcould have a cellRepository.EventControllercould have an engine.That way we don't have to pass these objects in every time we call methods. See how the
eventController.registermethod now only needs two arguments - an event string and a listener/handler/operator. Instead of also passing in an engine every time we register a listener (I've started calling them listeners now I'm afraid). A similar simplification is achieved by having theanimatorhave its own cellRepository, instead of passing that as an argument.A similar pattern could be followed for the cellFactory stuff. I.e. cellFactory could have a cellRepository. This would have the same benefit if we use our eventController to register a listener for collisions.
I think we we were concerned that we'd have to update each object's cellRepository if we do things this way (I know I was). But actually, this is why we pass objects in, instead of static arrays - so that these objects are updated across the entire app.