search

jennings / OATH.Net

A small library that implements the HOTP and TOTP algorithms for two-factor authentication. Compatible with the Google Authenticator app for iPhone and Android.
https://www.nuget.org/packages/OATH.Net/
28 stars 14 forks source link

Please provide strongly name key #12

Open docwattsman opened 6 years ago

docwattsman commented 6 years ago

Your code is great, but we were forced to fork it because it was not strongly signed. Could have been leveraged as-is, if only it had SNK in the project. Thank you for your hard work!

jennings commented 6 years ago

I've never set up strong naming before, but if you're willing to create a pull request that adds it to the build script, I'm open to merging it in.

The standard advice is for open source projects to check in their strong-naming key, so do include the key in the PR.

docwattsman commented 6 years ago

I could certainly try it. I am new to working in GitHub as a contributor on projects that are not mine. Do I need permission to do that?

From: Stephen Jennings notifications@github.com Sent: Tuesday, October 23, 2018 12:37 PM To: jennings/OATH.Net OATH.Net@noreply.github.com Cc: Thomas Carpe thomas.carpe@liquidmercurysolutions.com; Author author@noreply.github.com Subject: Re: [jennings/OATH.Net] Please provide strongly name key (#12)

I've never set up strong naming before, but if you're willing to create a pull request that adds it to the build script, I'm open to merging it in.

The standard advice is for open source projects to check in their strong-naming keyhttps://docs.microsoft.com/en-us/dotnet/standard/library-guidance/strong-naming, so do include the key in the PR.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/jennings/OATH.Net/issues/12#issuecomment-432322151, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ATLsxOB0SUFgWVdAX4Wj3DWPfhWF9F3wks5un0XIgaJpZM4Xyjht.

Did we do something great for you today? Maybe there’s something we could improve. Please take a few minutes to share your feedback with us.https://form.jotform.us/71425904727156

Do you need help with Office 365 or other Microsoft Services? Please email Help@liquidmercurysolutions.com to reach our support team or dial direct at 202-753-0107<tel:+12027530107>. Don't have a service agreement with us? Call us at 410-633-5959<tel:+14106335959> or email Sales@liquidmercurysolutions.com and let's get started.

jennings commented 6 years ago

Not at all! The process is:

  1. Fork this repository (there should be a "Fork" button in the upper-right). This puts a copy of the repo into your GitHub account.

  2. Clone that repository to your computer, write and commit the changes you want to make, then push it back to GitHub. (Most of the time you'd want to make a new branch for this work, but if you do it in the master branch I won't be picky.)

  3. Back on GitHub, open a pull request to merge your branch into my master branch.

It looks like there are many ways you can strong-name an assembly; my preference if possible would be for MSBuild to automatically sign the assembly when generating a Release build.

Thanks for looking into this!