jenningsloy318 / panos_exporter

paloalto os expoter for prometheus
Apache License 2.0
21 stars 16 forks source link

reverting zero metrics #17

Closed inetman28 closed 1 year ago

inetman28 commented 2 years ago

hi, I've noticed that sometimes panos_exporter reverts zero metrics

in first iteration:

curl http://pan-exporter.paloalto.local/panos\?target\=fw1.paloalto.local  | grep panos_session_session_pps
# HELP panos_session_session_pps Session info: packets per second
# TYPE panos_session_session_pps gauge
panos_session_session_pps{category="session",domain="statistics"} 950536

in following:

curl http://pan-exporter.paloalto.local/panos\?target\=fw1.paloalto.local  | grep panos_session_session_pps
# HELP panos_session_session_pps Session info: packets per second
# TYPE panos_session_session_pps gauge
panos_session_session_pps{category="session",domain="statistics"} 0

in grafana dashboard I see next picture image

that doesn't correlate to any kind of problem on device because the same "dashboard holes" I see on all devices with different platform

for example, another metric panos_global_counter_pkt_recv shows normal graph (without holes) image

pawelos99 commented 1 year ago

I have also noticed this while using the exporter, the root cause is a race in the code when using goreqest. Pull requests waits for comments and approval.