Closed NosIreland closed 4 years ago
At the very beginning, I also come across same confusion regarding if it is required to implement this, but finally decided not, two reasons here:
Thanks for info, here is my take:
I checked the gofish code, and indeed this is a struct that hold the PhysicalSecurity
data, at this point, I can add this metric.
and meanwihle, only one metric is possible, check whether if the IntrusionSensorReArm
is Manual
or Automatic
, and treat IntrusionSensor
and IntrusionSensorNumber
as the labels.
for log metrics, I need more consideration on this, minimal of the metrics to to collect the current entry counts, group them as different servirity, warning or critical, but here is also a tricky thing that the log entry will not be clear automatically, so this is always some value for this metric. and also the log entry timestamp is not irrelative with the metric timstamp, no easy to define the rules to determine the health state, so I think it is not practical here .
@NosIreland I update this exporter, implemented physical security part, you can grab the source code and raise a test for it now
No update for this issue, just close it
Would it be possible to add metric for log entries and intrusion detection. Both of these would change system/chassis health to warning or critical. But at the moment if there is no way in seeing what is causing warning/critical state of system when there is intrusion detection or entries in system logs. log entries: https://hostname/redfish/v1/Systems/1/LogServices/Log1/Entries
Intrusion: https://hostname/redfish/v1/Chassis/1