search

jenningsloy318 / redfish_exporter

exporter to get metrics from redfish based hardware such as lenovo/dell/superc servers
Apache License 2.0
70 stars 62 forks source link

ChassiCollector & SystemCollector- Error Scraping #25

Closed RyanW8 closed 2 years ago

RyanW8 commented 3 years ago

Hey getting this error

2020/11/23 17:18:30 error error getting power data from chassis Chassis=Self app=redfish_exporter collector=ChassisCollector error=json: cannot unmarshal number into Go struct field PowerControl.PowerControl.MemberId of type string operation=chassis.Power() target=REDACTED

As well as

2020/11/23 17:20:46 error error getting processor data from system System=Self app=redfish_exporter collector=SystemCollector error=json: cannot unmarshal string into Go struct field .MaxSpeedMHz of type int operation=system.Processors() target=REDACTED Any idea on what it could be?

RyanW8 commented 3 years ago

Also seems that scraping data is taking an extremely long time... I've only got 2 hosts hooked up atm; one is scraping in about 15 seconds which is good and this one is taking about 5 minutes which is an extremely long time. Possible to do with the errors?

jenningsloy318 commented 3 years ago

Hi,

Can you use curl to get what exactly data for PowerControl.PowerControl and MaxSpeedMHz as json and paste the output here?

RyanW8 commented 3 years ago

https://gist.github.com/RyanW8/42803cee457e5ebe6d198a2141224be6 This is for PowerControl Grabbed using https://<host_ip>/redfish/v1/Chassis/Self/Power. Looks to be that some MemberIDs are strings and some are numbers

https://gist.github.com/RyanW8/74c4904706b486e0862703d96c5f9235 This is the CPU information. Grabbed using https://<host_ip>/redfish/v1/System/Self/Processors/1 & https://<host_ip>/redfish/v1/System/Self/Processors/2. Looks like MaxSpeedMHz isn't set.

RyanW8 commented 3 years ago

https://github.com/stmcginnis/gofish/pull/100 I raised the issue upstream and they've made a PR to fix the handling of it. Can you please update the version of GoFish used to include this fix?

EDIT: PR has been merged & the issue closed upstream (https://github.com/stmcginnis/gofish/issues/99). The only action should be to update your dependencies to pull from the master branch of their repository. I don't think this is in any releases as of yet

jenningsloy318 commented 3 years ago

Hi Ryan,

I update the dependency, as this is just upstream fix, will not publish a new release, you can grab the code and build it on your side.

jenningsloy318 commented 3 years ago

@RyanW8 is this issue fixed ?