search

jenningsloy318 / redfish_exporter

exporter to get metrics from redfish based hardware such as lenovo/dell/superc servers
Apache License 2.0
70 stars 62 forks source link

No fan_id for redfish_chassis_fan_* metrics #4

Closed matejzero closed 4 years ago

matejzero commented 4 years ago

I managed to get the exporter working.

I noticed it doesn't collect fan_id in my case (Lenovo SR630). Looking at the Redfish response, this is what I get on my end (XCC 3.60):

...
        "CooledBy": [
            {
                "@odata.id": "/redfish/v1/Chassis/1/Thermal#/Fans/0"
            },

According to DMTF mockup (check Fans section), that should be correct output. But in your chassis sample you have an extra / before #. Is this a typo on your end or a bug in your Lenovo XCC version ?

There were some big changes regarding Redfish in XCC 3.00 and 3.60:

3.60: 
  - Added the support of Redfish 1.8.0 and new properties support.
  - Added the support to report Raid health

3.00:
  - Added the Redfish support of telemetry service with metric reports and SSE.
  - Added the Redfish support of 2019.1 schema and registries.
  - Added the Redfish support of firmware update with push method and enhanced the firmware update messages.
  - Added the Redfish support to get the PSU firmware inventory.
  - Added the Redfish support of IO adapter settings with Bios schema.
  - Added the Redfish support of Enclosure "Chassis" object on blade and dense systems.
jenningsloy318 commented 4 years ago

@matejzero my XCC version has different output as yours, and I will check the firm version on my server. and also this maybe invoke a upstream project changes.

and also can you file a whole sample set, I can check what changes in details.

matejzero commented 4 years ago

I tried version 2.70, but the URIs are correct. Unfortunately I don't have an older firmware running as I upgraded the last 2.10 today.

Output of `/redfish/v1/Chassis/1/

{
    "SerialNumber": "xxxxxxx",
    "@odata.id": "/redfish/v1/Chassis/1",
    "Links": {
        "Drives": [
            {
                "@odata.id": "/redfish/v1/Systems/1/Storage/RAID_Slot4/Drives/Disk.0"
            },
            {
                "@odata.id": "/redfish/v1/Systems/1/Storage/RAID_Slot4/Drives/Disk.1"
            }
        ],
        "CooledBy": [
            {
                "@odata.id": "/redfish/v1/Chassis/1/Thermal#/Fans/0"
            },
            {
                "@odata.id": "/redfish/v1/Chassis/1/Thermal#/Fans/1"
            },
            {
                "@odata.id": "/redfish/v1/Chassis/1/Thermal#/Fans/2"
            },
            {
                "@odata.id": "/redfish/v1/Chassis/1/Thermal#/Fans/3"
            },
            {
                "@odata.id": "/redfish/v1/Chassis/1/Thermal#/Fans/4"
            },
            {
                "@odata.id": "/redfish/v1/Chassis/1/Thermal#/Fans/5"
            },
            {
                "@odata.id": "/redfish/v1/Chassis/1/Thermal#/Fans/6"
            },
            {
                "@odata.id": "/redfish/v1/Chassis/1/Thermal#/Fans/7"
            },
            {
                "@odata.id": "/redfish/v1/Chassis/1/Thermal#/Fans/8"
            },
            {
                "@odata.id": "/redfish/v1/Chassis/1/Thermal#/Fans/9"
            },
            {
                "@odata.id": "/redfish/v1/Chassis/1/Thermal#/Fans/10"
            },
            {
                "@odata.id": "/redfish/v1/Chassis/1/Thermal#/Fans/11"
            },
            {
                "@odata.id": "/redfish/v1/Chassis/1/Thermal#/Fans/12"
            },
            {
                "@odata.id": "/redfish/v1/Chassis/1/Thermal#/Fans/13"
            }
        ],
        "ComputerSystems": [
            {
                "@odata.id": "/redfish/v1/Systems/1"
            }
        ],
        "PCIeDevices": [
            {
                "@odata.id": "/redfish/v1/Systems/1/PCIeDevices/ob_1"
            },
            {
                "@odata.id": "/redfish/v1/Systems/1/PCIeDevices/ob_2"
            },
            {
                "@odata.id": "/redfish/v1/Systems/1/PCIeDevices/ob_3"
            },
            {
                "@odata.id": "/redfish/v1/Systems/1/PCIeDevices/slot_1"
            },
            {
                "@odata.id": "/redfish/v1/Systems/1/PCIeDevices/slot_4"
            }
        ],
        "PoweredBy": [
            {
                "@odata.id": "/redfish/v1/Chassis/1/Power#/PowerSupplies/0"
            },
            {
                "@odata.id": "/redfish/v1/Chassis/1/Power#/PowerSupplies/1"
            }
        ],
        "Processors": [
            {
                "@odata.id": "/redfish/v1/Systems/1/Processors/1"
            },
            {
                "@odata.id": "/redfish/v1/Systems/1/Processors/2"
            }
        ],
        "ManagedBy": [
            {
                "@odata.id": "/redfish/v1/Managers/1"
            }
        ],
        "Storage": [
            {
                "@odata.id": "/redfish/v1/Systems/1/Storage/RAID_Slot4"
            }
        ],
        "ManagersInChassis": [
            {
                "@odata.id": "/redfish/v1/Managers/1"
            }
        ]
    },
    "PowerState": "On",
    "UUID": "xxxxxxx",
    "ChassisType": "RackMount",
    "PartNumber": "yyyyyyy",
    "Location": {
        "PartLocation": {},
        "Contacts": [
            {
                "ContactName": ""
            }
        ],
        "PostalAddress": {
            "Location": "",
            "Room": "",
            "Building": "",
            "Name": ""
        },
        "Placement": {
            "RackOffset": 0,
            "Rack": "",
            "RackOffsetUnits": ""
        }
    },
    "Oem": {
        "Lenovo": {
            "@odata.type": "#LenovoChassis.v1_0_0.LenovoChassisProperties",
            "Sensors": {
                "@odata.id": "/redfish/v1/Chassis/1/Oem/Lenovo/Sensors"
            },
            "ProductName": "ThinkSystem SR630",
            "LEDs": {
                "@odata.id": "/redfish/v1/Chassis/1/Oem/Lenovo/LEDs"
            },
            "Slots": {
                "@odata.id": "/redfish/v1/Chassis/1/Oem/Lenovo/Slots"
            }
        }
    },
    "Description": "This resource is used to represent a chassis or other physical enclosure for a Redfish implementation.",
    "Thermal": {
        "@odata.id": "/redfish/v1/Chassis/1/Thermal"
    },
    "Id": "1",
    "@odata.type": "#Chassis.v1_9_1.Chassis",
    "PCIeSlots": {
        "@odata.id": "/redfish/v1/Chassis/1/PCIeSlots"
    },
    "Status": {
        "State": "Enabled",
        "Health": "OK"
    },
    "Model": "",
    "Name": "Chassis",
    "HeightMm": 44.45,
    "Power": {
        "@odata.id": "/redfish/v1/Chassis/1/Power"
    },
    "SKU": "",
    "NetworkAdapters": {
        "@odata.id": "/redfish/v1/Chassis/1/NetworkAdapters"
    },
    "AssetTag": "",
    "Manufacturer": "Lenovo",
    "@odata.etag": "\"f444bbe185f3e7439db8d479050ca260\"",
    "LogServices": {
        "@odata.id": "/redfish/v1/Systems/1/LogServices"
    },
    "IndicatorLED": "Off"
}
jenningsloy318 commented 4 years ago

Can you please modify go.mod,change github.com/stmcginnis/gofish v0.2.0 to 0.4.0 and rebuild it ,and to see if it works

matejzero commented 4 years ago

I tried upgrading, but it still doesn't report fan_id. I also get some other errors (but these were present on v0.2.0 as well):

INFO[0015] Errors Getting memory from computer system : json: cannot unmarshal object into Go struct field .Location of type string  source="system_collector.go:386"
INFO[0016] Errors Getting Processors from system: json: cannot unmarshal object into Go struct field .Metrics of type string  source="system_collector.go:403"
jenningsloy318 commented 4 years ago

Hi @matejzero seems upstream don't fix this issue, and also some other changes introduced.

I will take some time to resolve this issue.

matejzero commented 4 years ago

Great! Let me know if I can help in any way (apart from coding, which is not my strong suit:P).

jenningsloy318 commented 4 years ago

@matejzero can you paste me a sample output of your memory and processor data , since the errors you showed may involve a upstream modification, so I have to create a pull request to upstream, but I need o figure out the correct way to modify it. 

INFO[0015] Errors Getting memory from computer system : json: cannot unmarshal object into Go struct field .Location of type string  source="system_collector.go:386"
INFO[0016] Errors Getting Processors from system: json: cannot unmarshal object into Go struct field .Metrics of type string  source="system_collector.go:403"

By the way, I made some changes, you can build it again to see if fan_id can be retrieved

matejzero commented 4 years ago

No, still no fan_id. But it should be there, MemberId field exists in the response.

This is a response I get from /redfish/v1/Chassis/1/Thermal#/Fans/1 endpoint:

{
    "Fans": [
        {
            "UpperThresholdFatal": null,
            "ReadingUnits": "Percent",
            "PhysicalContext": "SystemBoard",
            "MemberId": "0",
            "MinReadingRange": 0,
            "UpperThresholdCritical": null,
            "MaxReadingRange": 100,
            "RelatedItem": [
                {
                    "@odata.id": "/redfish/v1/Systems/1"
                },
                {
                    "@odata.id": "/redfish/v1/Chassis/1"
                }
            ],
            "Status": {
                "State": "Enabled",
                "Health": "OK"
            },
            "FanName": "Fan 1A Tach",
            "Reading": 24,
            "UpperThresholdNonCritical": null,
            "Oem": {
                "Lenovo": {
                    "Location": {
                        "Info": "Slot 1",
                        "InfoFormat": "Slot X"
                    }
                }
            },
            "LowerThresholdFatal": null,
            "Name": "Fan 1A Tach",
            "LowerThresholdNonCritical": null,
            "@odata.id": "/redfish/v1/Chassis/1/Thermal#/Fans/0",
            "LowerThresholdCritical": 3
        },
        {
            "UpperThresholdFatal": null,
            "ReadingUnits": "Percent",
            "PhysicalContext": "SystemBoard",
            "MemberId": "1",
            "MinReadingRange": 0,
            "UpperThresholdCritical": null,
            "MaxReadingRange": 100,
            "RelatedItem": [
                {
                    "@odata.id": "/redfish/v1/Systems/1"
                },
                {
                    "@odata.id": "/redfish/v1/Chassis/1"
                }
            ],
            "Status": {
                "State": "Enabled",
                "Health": "OK"
            },
            "FanName": "Fan 1B Tach",
            "Reading": 26,
            "UpperThresholdNonCritical": null,
            "Oem": {
                "Lenovo": {
                    "Location": {
                        "Info": "Slot 1",
                        "InfoFormat": "Slot X"
                    }
                }
            },
            "LowerThresholdFatal": null,
            "Name": "Fan 1B Tach",
            "LowerThresholdNonCritical": null,
            "@odata.id": "/redfish/v1/Chassis/1/Thermal#/Fans/1",
            "LowerThresholdCritical": 3
        },
        {
            "@odata.id": "/redfish/v1/Chassis/1/Thermal#/Fans/2",
            "ReadingUnits": "Percent",
            "PhysicalContext": "SystemBoard",
            "MemberId": "2",
            "MinReadingRange": 0,
            "UpperThresholdCritical": null,
            "MaxReadingRange": 100,
            "RelatedItem": [
                {
                    "@odata.id": "/redfish/v1/Systems/1"
                },
                {
                    "@odata.id": "/redfish/v1/Chassis/1"
                }
            ],
            "Status": {
                "State": "Enabled",
                "Health": "OK"
            },
            "FanName": "Fan 2A Tach",
            "Reading": 26,
            "UpperThresholdNonCritical": null,
            "Oem": {
                "Lenovo": {
                    "Location": {
                        "Info": "Slot 2",
                        "InfoFormat": "Slot X"
                    }
                }
            },
            "LowerThresholdFatal": null,
            "Name": "Fan 2A Tach",
            "LowerThresholdNonCritical": null,
            "UpperThresholdFatal": null,
            "LowerThresholdCritical": 3
        },
        {
            "UpperThresholdFatal": null,
            "ReadingUnits": "Percent",
            "PhysicalContext": "SystemBoard",
            "MemberId": "3",
            "MinReadingRange": 0,
            "UpperThresholdCritical": null,
            "MaxReadingRange": 100,
            "RelatedItem": [
                {
                    "@odata.id": "/redfish/v1/Systems/1"
                },
                {
                    "@odata.id": "/redfish/v1/Chassis/1"
                }
            ],
            "Status": {
                "State": "Enabled",
                "Health": "OK"
            },
            "FanName": "Fan 2B Tach",
            "Reading": 26,
            "UpperThresholdNonCritical": null,
            "Oem": {
                "Lenovo": {
                    "Location": {
                        "Info": "Slot 2",
                        "InfoFormat": "Slot X"
                    }
                }
            },
            "LowerThresholdFatal": null,
            "Name": "Fan 2B Tach",
            "LowerThresholdNonCritical": null,
            "@odata.id": "/redfish/v1/Chassis/1/Thermal#/Fans/3",
            "LowerThresholdCritical": 3
        },
        {
            "@odata.id": "/redfish/v1/Chassis/1/Thermal#/Fans/4",
            "ReadingUnits": "Percent",
            "PhysicalContext": "SystemBoard",
            "MemberId": "4",
            "MinReadingRange": 0,
            "UpperThresholdCritical": null,
            "MaxReadingRange": 100,
            "RelatedItem": [
                {
                    "@odata.id": "/redfish/v1/Systems/1"
                },
                {
                    "@odata.id": "/redfish/v1/Chassis/1"
                }
            ],
            "Status": {
                "State": "Enabled",
                "Health": "OK"
            },
            "FanName": "Fan 3A Tach",
            "Reading": 25,
            "UpperThresholdNonCritical": null,
            "Oem": {
                "Lenovo": {
                    "Location": {
                        "Info": "Slot 3",
                        "InfoFormat": "Slot X"
                    }
                }
            },
            "LowerThresholdFatal": null,
            "Name": "Fan 3A Tach",
            "LowerThresholdNonCritical": null,
            "UpperThresholdFatal": null,
            "LowerThresholdCritical": 3
        },
        {
            "UpperThresholdFatal": null,
            "ReadingUnits": "Percent",
            "PhysicalContext": "SystemBoard",
            "MemberId": "5",
            "MinReadingRange": 0,
            "UpperThresholdCritical": null,
            "MaxReadingRange": 100,
            "RelatedItem": [
                {
                    "@odata.id": "/redfish/v1/Systems/1"
                },
                {
                    "@odata.id": "/redfish/v1/Chassis/1"
                }
            ],
            "Status": {
                "State": "Enabled",
                "Health": "OK"
            },
            "FanName": "Fan 3B Tach",
            "Reading": 25,
            "UpperThresholdNonCritical": null,
            "Oem": {
                "Lenovo": {
                    "Location": {
                        "Info": "Slot 3",
                        "InfoFormat": "Slot X"
                    }
                }
            },
            "LowerThresholdFatal": null,
            "Name": "Fan 3B Tach",
            "LowerThresholdNonCritical": null,
            "@odata.id": "/redfish/v1/Chassis/1/Thermal#/Fans/5",
            "LowerThresholdCritical": 3
        },
        {
            "UpperThresholdFatal": null,
            "ReadingUnits": "Percent",
            "PhysicalContext": "SystemBoard",
            "MemberId": "6",
            "MinReadingRange": 0,
            "UpperThresholdCritical": null,
            "MaxReadingRange": 100,
            "RelatedItem": [
                {
                    "@odata.id": "/redfish/v1/Systems/1"
                },
                {
                    "@odata.id": "/redfish/v1/Chassis/1"
                }
            ],
            "Status": {
                "State": "Enabled",
                "Health": "OK"
            },
            "FanName": "Fan 4A Tach",
            "Reading": 25,
            "UpperThresholdNonCritical": null,
            "Oem": {
                "Lenovo": {
                    "Location": {
                        "Info": "Slot 4",
                        "InfoFormat": "Slot X"
                    }
                }
            },
            "LowerThresholdFatal": null,
            "Name": "Fan 4A Tach",
            "LowerThresholdNonCritical": null,
            "@odata.id": "/redfish/v1/Chassis/1/Thermal#/Fans/6",
            "LowerThresholdCritical": 3
        },
        {
            "@odata.id": "/redfish/v1/Chassis/1/Thermal#/Fans/7",
            "ReadingUnits": "Percent",
            "PhysicalContext": "SystemBoard",
            "MemberId": "7",
            "MinReadingRange": 0,
            "UpperThresholdCritical": null,
            "MaxReadingRange": 100,
            "RelatedItem": [
                {
                    "@odata.id": "/redfish/v1/Systems/1"
                },
                {
                    "@odata.id": "/redfish/v1/Chassis/1"
                }
            ],
            "Status": {
                "State": "Enabled",
                "Health": "OK"
            },
            "FanName": "Fan 4B Tach",
            "Reading": 26,
            "UpperThresholdNonCritical": null,
            "Oem": {
                "Lenovo": {
                    "Location": {
                        "Info": "Slot 4",
                        "InfoFormat": "Slot X"
                    }
                }
            },
            "LowerThresholdFatal": null,
            "Name": "Fan 4B Tach",
            "LowerThresholdNonCritical": null,
            "UpperThresholdFatal": null,
            "LowerThresholdCritical": 3
        },
        {
            "UpperThresholdFatal": null,
            "ReadingUnits": "Percent",
            "PhysicalContext": "SystemBoard",
            "MemberId": "8",
            "MinReadingRange": 0,
            "UpperThresholdCritical": null,
            "MaxReadingRange": 100,
            "RelatedItem": [
                {
                    "@odata.id": "/redfish/v1/Systems/1"
                },
                {
                    "@odata.id": "/redfish/v1/Chassis/1"
                }
            ],
            "Status": {
                "State": "Enabled",
                "Health": "OK"
            },
            "FanName": "Fan 5A Tach",
            "Reading": 25,
            "UpperThresholdNonCritical": null,
            "Oem": {
                "Lenovo": {
                    "Location": {
                        "Info": "Slot 5",
                        "InfoFormat": "Slot X"
                    }
                }
            },
            "LowerThresholdFatal": null,
            "Name": "Fan 5A Tach",
            "LowerThresholdNonCritical": null,
            "@odata.id": "/redfish/v1/Chassis/1/Thermal#/Fans/8",
            "LowerThresholdCritical": 3
        },
        {
            "@odata.id": "/redfish/v1/Chassis/1/Thermal#/Fans/9",
            "ReadingUnits": "Percent",
            "PhysicalContext": "SystemBoard",
            "MemberId": "9",
            "MinReadingRange": 0,
            "UpperThresholdCritical": null,
            "MaxReadingRange": 100,
            "RelatedItem": [
                {
                    "@odata.id": "/redfish/v1/Systems/1"
                },
                {
                    "@odata.id": "/redfish/v1/Chassis/1"
                }
            ],
            "Status": {
                "State": "Enabled",
                "Health": "OK"
            },
            "FanName": "Fan 5B Tach",
            "Reading": 25,
            "UpperThresholdNonCritical": null,
            "Oem": {
                "Lenovo": {
                    "Location": {
                        "Info": "Slot 5",
                        "InfoFormat": "Slot X"
                    }
                }
            },
            "LowerThresholdFatal": null,
            "Name": "Fan 5B Tach",
            "LowerThresholdNonCritical": null,
            "UpperThresholdFatal": null,
            "LowerThresholdCritical": 3
        },
        {
            "UpperThresholdFatal": null,
            "ReadingUnits": "Percent",
            "PhysicalContext": "SystemBoard",
            "MemberId": "10",
            "MinReadingRange": 0,
            "UpperThresholdCritical": null,
            "MaxReadingRange": 100,
            "RelatedItem": [
                {
                    "@odata.id": "/redfish/v1/Systems/1"
                },
                {
                    "@odata.id": "/redfish/v1/Chassis/1"
                }
            ],
            "Status": {
                "State": "Enabled",
                "Health": "OK"
            },
            "FanName": "Fan 6A Tach",
            "Reading": 25,
            "UpperThresholdNonCritical": null,
            "Oem": {
                "Lenovo": {
                    "Location": {
                        "Info": "Slot 6",
                        "InfoFormat": "Slot X"
                    }
                }
            },
            "LowerThresholdFatal": null,
            "Name": "Fan 6A Tach",
            "LowerThresholdNonCritical": null,
            "@odata.id": "/redfish/v1/Chassis/1/Thermal#/Fans/10",
            "LowerThresholdCritical": 3
        },
        {
            "@odata.id": "/redfish/v1/Chassis/1/Thermal#/Fans/11",
            "ReadingUnits": "Percent",
            "PhysicalContext": "SystemBoard",
            "MemberId": "11",
            "MinReadingRange": 0,
            "UpperThresholdCritical": null,
            "MaxReadingRange": 100,
            "RelatedItem": [
                {
                    "@odata.id": "/redfish/v1/Systems/1"
                },
                {
                    "@odata.id": "/redfish/v1/Chassis/1"
                }
            ],
            "Status": {
                "State": "Enabled",
                "Health": "OK"
            },
            "FanName": "Fan 6B Tach",
            "Reading": 26,
            "UpperThresholdNonCritical": null,
            "Oem": {
                "Lenovo": {
                    "Location": {
                        "Info": "Slot 6",
                        "InfoFormat": "Slot X"
                    }
                }
            },
            "LowerThresholdFatal": null,
            "Name": "Fan 6B Tach",
            "LowerThresholdNonCritical": null,
            "UpperThresholdFatal": null,
            "LowerThresholdCritical": 3
        },
        {
            "@odata.id": "/redfish/v1/Chassis/1/Thermal#/Fans/12",
            "ReadingUnits": "Percent",
            "PhysicalContext": "SystemBoard",
            "MemberId": "12",
            "MinReadingRange": 0,
            "UpperThresholdCritical": null,
            "MaxReadingRange": 100,
            "RelatedItem": [
                {
                    "@odata.id": "/redfish/v1/Systems/1"
                },
                {
                    "@odata.id": "/redfish/v1/Chassis/1"
                }
            ],
            "Status": {
                "State": "Enabled",
                "Health": "OK"
            },
            "FanName": "Fan 7A Tach",
            "Reading": 25,
            "UpperThresholdNonCritical": null,
            "Oem": {
                "Lenovo": {
                    "Location": {
                        "Info": "Slot 7",
                        "InfoFormat": "Slot X"
                    }
                }
            },
            "LowerThresholdFatal": null,
            "Name": "Fan 7A Tach",
            "LowerThresholdNonCritical": null,
            "UpperThresholdFatal": null,
            "LowerThresholdCritical": 3
        },
        {
            "UpperThresholdFatal": null,
            "ReadingUnits": "Percent",
            "PhysicalContext": "SystemBoard",
            "MemberId": "13",
            "MinReadingRange": 0,
            "UpperThresholdCritical": null,
            "MaxReadingRange": 100,
            "RelatedItem": [
                {
                    "@odata.id": "/redfish/v1/Systems/1"
                },
                {
                    "@odata.id": "/redfish/v1/Chassis/1"
                }
            ],
            "Status": {
                "State": "Enabled",
                "Health": "OK"
            },
            "FanName": "Fan 7B Tach",
            "Reading": 25,
            "UpperThresholdNonCritical": null,
            "Oem": {
                "Lenovo": {
                    "Location": {
                        "Info": "Slot 7",
                        "InfoFormat": "Slot X"
                    }
                }
            },
            "LowerThresholdFatal": null,
            "Name": "Fan 7B Tach",
            "LowerThresholdNonCritical": null,
            "@odata.id": "/redfish/v1/Chassis/1/Thermal#/Fans/13",
            "LowerThresholdCritical": 3
        }
    ],
    "@odata.id": "/redfish/v1/Chassis/1/Thermal",
    "Status": {
        "State": "Enabled",
        "HealthRollup": "OK"
    },
    "Temperatures@odata.count": 11,
    "Name": "Thermal",
    "Oem": {
        "Lenovo": {
            "@odata.type": "#LenovoThermal.v1_0_0.Thermal",
            "HistoryTempMetric": {
                "@odata.id": "/redfish/v1/Chassis/1/Thermal/Oem/Lenovo/HistoryTempMetric"
            }
        }
    },
    "@odata.type": "#Thermal.v1_5_2.Thermal",
    "Temperatures": [
        {
            "LowerThresholdFatal": null,
            "LowerThresholdNonCritical": null,
            "RelatedItem": [
                {
                    "@odata.id": "/redfish/v1/Systems/1"
                },
                {
                    "@odata.id": "/redfish/v1/Chassis/1"
                }
            ],
            "ReadingCelsius": 24,
            "Status": {
                "State": "Enabled"
            },
            "SensorNumber": 128,
            "Name": "Ambient Temp",
            "MaxReadingRangeTemp": 100,
            "UpperThresholdNonCritical": 43,
            "MinReadingRangeTemp": 0,
            "MemberId": "0",
            "LowerThresholdCritical": null,
            "PhysicalContext": "Intake",
            "UpperThresholdCritical": 47,
            "UpperThresholdFatal": 50,
            "@odata.id": "/redfish/v1/Chassis/1/Thermal#/Temperatures/0"
        },
        {
            "LowerThresholdFatal": null,
            "LowerThresholdNonCritical": null,
            "RelatedItem": [
                {
                    "@odata.id": "/redfish/v1/Systems/1/Processors/1"
                }
            ],
            "@odata.id": "/redfish/v1/Chassis/1/Thermal#/Temperatures/1",
            "Status": {
                "State": "Enabled"
            },
            "SensorNumber": 132,
            "Name": "CPU1 Temp",
            "MaxReadingRangeTemp": null,
            "UpperThresholdNonCritical": null,
            "MinReadingRangeTemp": 0,
            "MemberId": "1",
            "LowerThresholdCritical": null,
            "PhysicalContext": "CPU",
            "UpperThresholdCritical": null,
            "ReadingCelsius": 39,
            "UpperThresholdFatal": null
        },
        {
            "LowerThresholdFatal": null,
            "LowerThresholdNonCritical": null,
            "RelatedItem": [
                {
                    "@odata.id": "/redfish/v1/Systems/1/Processors/1"
                }
            ],
            "@odata.id": "/redfish/v1/Chassis/1/Thermal#/Temperatures/2",
            "Status": {
                "State": "Enabled"
            },
            "SensorNumber": 80,
            "Name": "CPU1 DTS",
            "MaxReadingRangeTemp": 0,
            "UpperThresholdNonCritical": null,
            "MinReadingRangeTemp": -51,
            "MemberId": "2",
            "LowerThresholdCritical": null,
            "PhysicalContext": "CPU",
            "UpperThresholdCritical": 0,
            "ReadingCelsius": -49,
            "UpperThresholdFatal": 0
        },
        {
            "LowerThresholdFatal": null,
            "LowerThresholdNonCritical": null,
            "RelatedItem": [
                {
                    "@odata.id": "/redfish/v1/Systems/1/Processors/2"
                }
            ],
            "@odata.id": "/redfish/v1/Chassis/1/Thermal#/Temperatures/3",
            "Status": {
                "State": "Enabled"
            },
            "SensorNumber": 134,
            "Name": "CPU2 Temp",
            "MaxReadingRangeTemp": null,
            "UpperThresholdNonCritical": null,
            "MinReadingRangeTemp": 0,
            "MemberId": "3",
            "LowerThresholdCritical": null,
            "PhysicalContext": "CPU",
            "UpperThresholdCritical": null,
            "ReadingCelsius": 37,
            "UpperThresholdFatal": null
        },
        {
            "LowerThresholdFatal": null,
            "LowerThresholdNonCritical": null,
            "RelatedItem": [
                {
                    "@odata.id": "/redfish/v1/Systems/1/Processors/2"
                }
            ],
            "@odata.id": "/redfish/v1/Chassis/1/Thermal#/Temperatures/4",
            "Status": {
                "State": "Enabled"
            },
            "SensorNumber": 81,
            "Name": "CPU2 DTS",
            "MaxReadingRangeTemp": 0,
            "UpperThresholdNonCritical": null,
            "MinReadingRangeTemp": -51,
            "MemberId": "4",
            "LowerThresholdCritical": null,
            "PhysicalContext": "CPU",
            "UpperThresholdCritical": 0,
            "ReadingCelsius": -51,
            "UpperThresholdFatal": 0
        },
        {
            "LowerThresholdFatal": null,
            "LowerThresholdNonCritical": null,
            "RelatedItem": [
                {
                    "@odata.id": "/redfish/v1/Systems/1"
                },
                {
                    "@odata.id": "/redfish/v1/Chassis/1"
                }
            ],
            "UpperThresholdFatal": null,
            "Status": {
                "State": "Enabled"
            },
            "SensorNumber": 52,
            "Name": "DIMM 5 Temp",
            "MaxReadingRangeTemp": null,
            "UpperThresholdNonCritical": null,
            "MinReadingRangeTemp": null,
            "MemberId": "5",
            "LowerThresholdCritical": null,
            "PhysicalContext": "Memory",
            "UpperThresholdCritical": null,
            "ReadingCelsius": 35,
            "@odata.id": "/redfish/v1/Chassis/1/Thermal#/Temperatures/5"
        },
        {
            "LowerThresholdFatal": null,
            "LowerThresholdNonCritical": null,
            "RelatedItem": [
                {
                    "@odata.id": "/redfish/v1/Systems/1"
                },
                {
                    "@odata.id": "/redfish/v1/Chassis/1"
                }
            ],
            "@odata.id": "/redfish/v1/Chassis/1/Thermal#/Temperatures/6",
            "Status": {
                "State": "Enabled"
            },
            "SensorNumber": 55,
            "Name": "DIMM 8 Temp",
            "MaxReadingRangeTemp": null,
            "UpperThresholdNonCritical": null,
            "MinReadingRangeTemp": null,
            "MemberId": "6",
            "LowerThresholdCritical": null,
            "PhysicalContext": "Memory",
            "UpperThresholdCritical": null,
            "ReadingCelsius": 35,
            "UpperThresholdFatal": null
        },
        {
            "LowerThresholdFatal": null,
            "LowerThresholdNonCritical": null,
            "RelatedItem": [
                {
                    "@odata.id": "/redfish/v1/Systems/1"
                },
                {
                    "@odata.id": "/redfish/v1/Chassis/1"
                }
            ],
            "@odata.id": "/redfish/v1/Chassis/1/Thermal#/Temperatures/7",
            "Status": {
                "State": "Enabled"
            },
            "SensorNumber": 64,
            "Name": "DIMM 17 Temp",
            "MaxReadingRangeTemp": null,
            "UpperThresholdNonCritical": null,
            "MinReadingRangeTemp": null,
            "MemberId": "7",
            "LowerThresholdCritical": null,
            "PhysicalContext": "Memory",
            "UpperThresholdCritical": null,
            "ReadingCelsius": 32,
            "UpperThresholdFatal": null
        },
        {
            "LowerThresholdFatal": null,
            "LowerThresholdNonCritical": null,
            "RelatedItem": [
                {
                    "@odata.id": "/redfish/v1/Systems/1"
                },
                {
                    "@odata.id": "/redfish/v1/Chassis/1"
                }
            ],
            "@odata.id": "/redfish/v1/Chassis/1/Thermal#/Temperatures/8",
            "Status": {
                "State": "Enabled"
            },
            "SensorNumber": 67,
            "Name": "DIMM 20 Temp",
            "MaxReadingRangeTemp": null,
            "UpperThresholdNonCritical": null,
            "MinReadingRangeTemp": null,
            "MemberId": "8",
            "LowerThresholdCritical": null,
            "PhysicalContext": "Memory",
            "UpperThresholdCritical": null,
            "ReadingCelsius": 33,
            "UpperThresholdFatal": null
        },
        {
            "LowerThresholdFatal": null,
            "LowerThresholdNonCritical": null,
            "RelatedItem": [
                {
                    "@odata.id": "/redfish/v1/Systems/1"
                },
                {
                    "@odata.id": "/redfish/v1/Chassis/1"
                }
            ],
            "ReadingCelsius": 49,
            "Status": {
                "State": "Enabled"
            },
            "SensorNumber": 47,
            "Name": "PCH Temp",
            "MaxReadingRangeTemp": null,
            "UpperThresholdNonCritical": null,
            "MinReadingRangeTemp": null,
            "MemberId": "9",
            "LowerThresholdCritical": null,
            "PhysicalContext": "ComputeBay",
            "UpperThresholdCritical": null,
            "UpperThresholdFatal": null,
            "@odata.id": "/redfish/v1/Chassis/1/Thermal#/Temperatures/9"
        },
        {
            "LowerThresholdFatal": null,
            "LowerThresholdNonCritical": null,
            "RelatedItem": [
                {
                    "@odata.id": "/redfish/v1/Systems/1"
                },
                {
                    "@odata.id": "/redfish/v1/Chassis/1"
                }
            ],
            "ReadingCelsius": 33,
            "Status": {
                "State": "Enabled"
            },
            "SensorNumber": 131,
            "Name": "Exhaust Temp",
            "MaxReadingRangeTemp": 100,
            "UpperThresholdNonCritical": null,
            "MinReadingRangeTemp": 0,
            "MemberId": "10",
            "LowerThresholdCritical": null,
            "PhysicalContext": "Exhaust",
            "UpperThresholdCritical": null,
            "UpperThresholdFatal": null,
            "@odata.id": "/redfish/v1/Chassis/1/Thermal#/Temperatures/10"
        }
    ],
    "Id": "1",
    "@odata.etag": "\"af94f5308c03d2b66e22761c43046667\"",
    "Fans@odata.count": 14,
    "Description": "It represents the properties for Temperature and Cooling."
}

It looks on-pair with mockup: https://redfish.dmtf.org/redfish/mockups/v1/922#

I migrated memory and processors problems to separate issue:

matejzero commented 4 years ago

Should we move Processor and Memory errors to another thread, so we won't clutter this one?