jenningsloy318 / redfish_exporter

exporter to get metrics from redfish based hardware such as lenovo/dell/superc servers
Apache License 2.0
70 stars 61 forks source link

Collect fan low/hi RPMs thresholds and properly compute fan percentage #50

Closed dylngg closed 2 years ago

dylngg commented 2 years ago

The chassis_fan_rpm metric (aka Reading) currently assumes that the reported fan value unit is a percentage, whereas the unit is informed by the ReadingUnits. To fix this I've added a chassis_fan_rpm_percentage metric that reports this percentage, regardless of whether the unit is RPM or Percentage, and added a fan_unit label to the original chassis_fan_rpm metric to indicate what unit the raw value is. (this means the chassis_fan_rpm metric won't change for users)

In addition, I've also exported the Min/MaxReadingRange, LowerThresholdCritical, LowerThresholdNonCritical, LowerThresholdFatal, UpperThresholdCritical, UpperThresholdNonCritical, and UpperThresholdFatal values. I've seen these be null for some servers though.

I've added some of the devices I tested on to the README. I'm assuming "supported" doesn't mean all values are non-null, just that the exporter works on them and exports all possible metrics.

Closes #42

As an aside, many thanks for this piece of software, it has been extremely useful for me!