jenningsloy318 / redfish_exporter

exporter to get metrics from redfish based hardware such as lenovo/dell/superc servers
Apache License 2.0
70 stars 61 forks source link

Add chassis model, manufacturer, and part number in metadata metric #52

Closed dylngg closed 2 years ago

dylngg commented 2 years ago

This MR exports the "Manufacturer", "Model", and "PartNumber" fields within each chassis with a metadata metric.

I'll note that I'm not sure if these labels should just be a part of every chassis metric, rather than having an individual *_info metric for storing them. If we had it in every metric it would be really easy to e.g. query all Dell or PowerEdge C6420 devices with a singular statement. But, I'm also not a fan of having a lot of labels per metric either and there are Prometheus querying tricks [0] that can be done to do the same thing.

[0] https://www.robustperception.io/exposing-the-software-version-to-prometheus