search

jenningsloy318 / redfish_exporter

exporter to get metrics from redfish based hardware such as lenovo/dell/superc servers
Apache License 2.0
76 stars 62 forks source link

Exporter has Difficulty with Duplicate Disk Names on Different Enclosures #81

Open burdorff opened 9 months ago

burdorff commented 9 months ago

We're running a Dell server with attached MD1400 with additional storage - and while all the data is available in the IDRAC (and subsequently to redfish API), the exporter struggles with duplicate labels where the disk names are the same on different enclosures. The distinguishing label would be the enclosure name, but this doesn't seem to be considered in the exporter.

An example:

* [from Gatherer #2] collected metric "redfish_system_simple_storage_device_state" { label:<name:"device" value:"Physical Disk 0:1:5" > label:<name:"hostname" value:"--removed hostname--" > label:<name:"resource" value:"device" > gauge:<value:1 > } was collected before with the same name and label values
* [from Gatherer #2] collected metric "redfish_system_simple_storage_device_health_state" { label:<name:"device" value:"Physical Disk 0:1:5" > label:<name:"hostname" value:"--removed hostname--" > label:<name:"resource" value:"device" > gauge:<value:1 > } was collected before with the same name and label values

Screenshot 2024-02-14 145002

burdorff commented 9 months ago

https://ip/redfish/v1/Systems/System.Embedded.1/Storage/RAID.Integrated.1-1 ... {"@odata.id":"/redfish/v1/Systems/System.Embedded.1/Storage/RAID.Integrated.1-1/Drives/Disk.Bay.5:Enclosure.Internal.0-1:RAID.Integrated.1-1"} ... https://ip/redfish/v1/Systems/System.Embedded.1/Storage/RAID.Slot.1-1 ... {"@odata.id":"/redfish/v1/Systems/System.Embedded.1/Storage/RAID.Slot.1-1/Drives/Disk.Bay.5:Enclosure.External.0-1:RAID.Slot.1-1"} ...