New year's code cleanup

edelooff commented 8 years ago

So here's a massive set of changes to the inner workings of timbles. There's a bit of back and forth in some of the commits so I may squash some together, refactor other bits and stuff, but the outcome should remain largely the same.

What this mainly does:

Remove duplicate code (like enablePagination() including goToPage(1) and smaller scale)
Remove early exits due to improper caller use (error hiding is bad; you shouldn't .timbles() on improper selectors, and if you do, you deserve an error)
Remove code / properties that doesn't do or change anything
Remove unnecessary jQuerifying of this and binding scopes to remove the need for aliasing;
Creation of HTML elements by attribute manipulation rather than string concats
Make better use of method chaining to express actions

Very much open for feedback

Happy New Year :fireworks:

edelooff commented 8 years ago

Did a bunch of rebasing to remove some clutter and make the history a bit nicer. Most commits now do a single thing and do it fairly completely, though some squashing might still be required.

edelooff commented 8 years ago

Hey @jennschiffer, I realize this PR is particularly large and touches basically all the code, but it would be awesome if you could find some time to review it and give it your :+1:.

All tests still pass, and as far as I've played around locally, all untested behavior (actual page switching and the like) is still the same as before. And now that I've mentioned it, I'll have a good think about adding tests for that, because we should have that automated really :smile:

jennschiffer commented 8 years ago

yes yes - i typically get time on fridays for "open source" time so I'll be taking a look at all this tomorrow! sorry for the wait!

jennschiffer commented 8 years ago

this all looks great! :+1:

jennschiffer / timbles.js

New year's code cleanup #21