Closed edelooff closed 8 years ago
@jennschiffer, could you let me know whether this needs anything else/different, or whether you're happy with the proposed changes?
hi! i'll have time on friday to take a look at all of this and test it out!
Hi @jennschiffer, did you get a change to look at this yet?
Hey Jenn, could you have a look at this so we can move this out of PR limbo?
sorry for the wait, been v busy :santa:
Hey @jennschiffer,
In order for #5 to be handled in an extension, some things need to be exposed (methods), and it makes sense to make some other small changes in the name of single-responsibility. So this PR brings the following (API) changes:
selectColumnHeaders()
, no longer split between pre-existing tables and generated onestableRows
'cache' is also moved to a function,selectTableBody()
configureTable()
function, which is executed for both pre-existing and generated tables. This replacessetupExistingTable()
andenableFeatures()
and makes the two kinds of tables more similar in operation.classes
,copy
andmethods
to the outside world, allowing plugins to hook into / replace methods with altered behavior.Exposing all the methods wholesale like this feels a bit crude, but I don't see a clear and better way (though there probably is).
Other small changes:
generateRowsFromData()
which allows for a significant simplification of generating table content from Array / JSON;parseInt()
call.