search

jennschiffer / timbles.js

a very simple jQuery plugin for tables, made by the person who literally did not invent tables
MIT License
38 stars 4 forks source link

Fix TypeError with nested column header cells #40

Closed edelooff closed 7 years ago

edelooff commented 7 years ago

Fixes a bug where clicking on a nested column header (<th><span>Header</span></th>) would cause a TypeError due to the incorrect event target being read. Reading the column header from event.currentTarget instead of event.target fixes this.

Included is the fix itself, a test, version bump and changelog update.

edelooff commented 7 years ago

@jennschiffer could you verify this doesn't do things in still-a-dumb-way?

jennschiffer commented 7 years ago

👍 merged & thanks! are you able to run npm publish since I don't have the credentials set up on my current machine at the moment. if not, let me know and i can run it later.

edelooff commented 7 years ago

NPM publication done.