search

jennykim1016 / OM10

Tools for working with the Oguri & Marshall (2010) mock catalog of strong gravitational lenses
MIT License
0 stars 0 forks source link

Make sure to check the capitalization #4

Closed jennykim1016 closed 7 years ago

jennykim1016 commented 7 years ago

I should change all the uppercase magnitudes to the lowercase magnitudes. Line 6 does not change that -- I should change plotting.py.

jennykim1016 commented 7 years ago

For this paper, the magnitudes are in CFHT, but they could easily be converted to SDSS magnitudes by considering offsets of zeropoints. This seems to contain some useful information.

drphilmarshall commented 7 years ago

Nice catch, Jenny. Looks like those 0.05 mag corrections are small enough to ignore to first order, would you say?

On Fri, Jan 27, 2017 at 12:11 AM, Jenny Kim notifications@github.com wrote:

For this http://iopscience.iop.org/article/10.1088/0004-637X/777/2/97/meta#apj485108t5 paper, the magnitudes are in CFHT, but they could easily be converted to SDSS magnitudes by considering offsets of zeropoints. This http://terapix.iap.fr/article.php?id_article=713 seems to contain some useful information.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jennykim1016/OM10/issues/4#issuecomment-275610750, or mute the thread https://github.com/notifications/unsubscribe-auth/AArY9xi0-B6geLquKWNsG0EUTJoHP1VDks5rWabMgaJpZM4LvVod .

jennykim1016 commented 7 years ago

Yes, I will ignore the discrepancies. Thanks!

jennykim1016 commented 7 years ago

1) In addition to this, for QuasarColorComparison, I should fix OM10 to make it read the .csv or .txt data as well. Currently, it just allows me to read .fits data. If that is too much, I can just set the constructor equal to the input data in the body of the notebook.

2) The style for Alessandro et al. notebook needs some improvements. I should write comments and improve the readability.

Edit : Everything resolved. Closing the issue.