fix bug that causes bottom margin option (-b) to be ignored

jenom / pdfbook2

Create booklets from PDF files

GNU General Public License v3.0

60 stars 13 forks source link

fix bug that causes bottom margin option (-b) to be ignored #11

Open AvanRocks opened 3 years ago

AvanRocks commented 3 years ago

Fixed a typo that caused opts.outerMargin to be used in place of opts.bottomMargin when setting the bottom of the bounding box for pdfcrop

AvanRocks commented 3 years ago

I added 2 more commits that fix another (related) bug. The bug was that pdfcrop was being passed the parameters for the bounding boxes in the wrong order. Instead of Left, Bottom, Right, Top (as mentioned by pdfcrop --help ), the options were being passed as Left, Top, Right, Bottom, which meant that Top and Bottom were being swapped.

ChasingZenith commented 2 years ago

Thank you for your bug fix. I also found this bug here @AvanRocks ! I think I will be better to rename maxB by maxT and minT by minB. Please kindly accept this pull request. @jenom

ChasingZenith commented 2 years ago

Done in my New pull request #16.