search

jens-maus / RaspberryMatic

:house: A feature-rich but lightweight, buildroot-based Linux operating system alternative for your CloudFree CCU3/ELV-Charly 'homematicIP CCU' IoT smarthome central. Running as a pure virtual appliance (ProxmoxVE, Home Assistant, LXC, Docker/OCI, Kubernetes/K8s, etc.) on a dedicated embedded device (RaspberryPi, etc.) or generic x86/ARM hardware.
https://raspberrymatic.de
Apache License 2.0
1.53k stars 186 forks source link

Network changes do not take effect without manual reboot #1109

Open srunschke opened 3 years ago

srunschke commented 3 years ago

Changes to the network are not reflected immediately, but need a reboot. Reason might be a wrong command in network.cgi, trying to call "/etc/init/network" - which does not exist. But my tcl/tk is not good enough to actually understand if cp_network.cgi calls network.cgi at all or if it is a leftover from old times.

Steps to reproduce the behavior

  1. Change something in the network settings
  2. Save
  3. Nothing has actually changed in the active network settings.

Expected behavior

Changes to the network settings should be reflected immediately through restarting the network (e.g. /etc/init.d/S40network restart). The best solution would actually be to test out the new settings and revert if simple checks (ping gateway, etc.pp) fail. Elsewise it should at least give a popup saying something like "Reboot needed for the changes to take effect. Reboot now?"

Screenshots Not needed

System information:

Additional context Needs to be fixed upstream imho.

jens-maus commented 3 years ago

Where in the official eQ3 CCU documentation is it stated that network configuration changes should not require any reboot? I think it is perfectly normal and common sense that upon changing the network settings a reboot is required.

srunschke commented 3 years ago

I never said it's in the documentation. Actually it would make me really wonder if bugs oder enhancement requests would already be in the documentation...

And honestly, I think most people would expect it to work that way, no matter what the documentation says. In the end it's common sense. If I change something, it is changed. If for some reason the change cannot be activated online, a good software at least tells me about that fact and asks me if I want to reboot. Following your argumentation - why does the RM ask me for a reboot after changing the certificate?

jens-maus commented 3 years ago

Simply, because the CCU3 is doing this and we are still using a good bunch of upstream code borrowed from eQ3. But if you feel that something should be changed in this area, feel free to submit a pull request with the necessary changes.

srunschke commented 3 years ago

I know, but if I remember correctly it was you who said: if you want something changed in OCCU, better post it here, because no one really cares about issues at OCCU. ;)

And as I already said, I do not really know tcl/tk good. So a pull request would rather be of questionable quality. I could give it a try though - but then I would have to do the pull req against OCCU, or not?