search

jens-maus / RaspberryMatic

:house: A feature-rich but lightweight, buildroot-based Linux operating system alternative for your CloudFree CCU3/ELV-Charly 'homematicIP CCU' IoT smarthome central. Running as a pure virtual appliance (ProxmoxVE, Home Assistant, LXC, Docker/OCI, Kubernetes/K8s, etc.) on a dedicated embedded device (RaspberryPi, etc.) or generic x86/ARM hardware.
https://raspberrymatic.de
Apache License 2.0
1.52k stars 186 forks source link

Device Firmware page column filters use German button labels when language is set to English #1652

Closed udochrist closed 2 years ago

udochrist commented 2 years ago

Describe the issue you are experiencing

The labels are „Setzen“ and „Schliessen“ instead of „Set“ and „Close“ as everywhere else when the language is set to English.

07AB02F6-2604-4563-BCAE-C0DA81FD92DD 53DE4783-C7BA-4230-B228-185D7CAC46B8

Describe the behavior you expected

English naming is used when English language settings are active.

Steps to reproduce the issue

  1. set language to English
  2. Open device firmware page
  3. Open any column filter

What is the version this bug report is based on?

3.61.7.20211218

Which base platform are you running?

rpi3 (RaspberryPi3)

Which HomeMatic/homematicIP radio module are you using?

RPI-RF-MOD

Anything in the logs that might be useful for us?

None

Additional information

None

udochrist commented 2 years ago

On a second note: I think the better English terms would be „Ok“ and „Cancel“ instead of Set and Close as this is what the buttons are supposed to do. However this would be a change affecting any such filter. So at least get them all to use the correct language.

andrzejgilas commented 2 years ago

ee

RM 3.61.7.20220105 with Firefox - all is OK

jens-maus commented 2 years ago

@andrzejgilas You missed that the author of this ticket meant the Settings -> Device firmware - overview pages only. Because I can perfectly reproduce the issue here.

andrzejgilas commented 2 years ago

2 that's right, my mistake :-)