search

jens-maus / yam

:mailbox_with_mail: YAM (short for 'Yet Another Mailer') is a MIME-compliant open-source Internet email client written for Amiga-based computer systems (AmigaOS4, AmigaOS3, MorphOS, AROS). It supports POP3, SMTP, TLSv1/SSLv3 connection security, multiple users, multiple identities, PGPv2/v5 encryption, unlimited hierarchical folders, an ARexx interface, etc...
https://yam.ch
GNU General Public License v2.0
62 stars 18 forks source link

Crash when clicking on Start while the email list is being retrieved #590

Closed jens-maus closed 8 years ago

jens-maus commented 8 years ago

Originally by pferrucci@sfr.fr on 2014-11-07 22:42:14 +0100

Summary

Steps to reproduce

  1. I click get, the "retrieving window" opens
  2. while the list is being populated in the window, I immediately click on Start or Abort
  3. crash occurs

    Expected results

    Actual results

Crashlog attached done with debug version

Regression

Notes

Yam debug 16/10/2014

jens-maus commented 8 years ago

Originally by pferrucci@sfr.fr on 2014-11-07 22:42:29 +0100

Attachment added: yam.txt (12.7 KiB)

tboeckel commented 8 years ago

Originally on 2014-11-09 20:19:33 +0100

I this reproducable in any way and does this happen every time for you? I never experienced such a crash yet. Usually I use the preselection window for large mails (>1MB) only and hence I see it quite seldom only, but it never caused any crashes and fetching all the details from the server takes a long time for me as there are waiting approx 25000 mails there. So usually YAM nevers finishes the details when I click on "Start".

jens-maus commented 8 years ago

Originally by pferrucci@sfr.fr on 2014-11-09 20:35:10 +0100

Well I reproduced 3 or 4 times before filling the bug report. Now I can't anymore :-(

It could be caused by some text in the subject of my emails that I now deleted. Will be hard to reproduce :-(

tboeckel commented 8 years ago

Originally on 2014-11-09 21:15:32 +0100

Well, if a specific subject should really be the cause, then it should happen anytime again, because due to the crash you did not download the mail and hence the next time the preselection window is shown the mail should trigger the crash again.

jens-maus commented 8 years ago

Originally by pferrucci@sfr.fr on 2014-11-09 22:15:02 +0100

But in the meantime I deleted non wanted emails, silly me :-( That's why I don't have the crash anymore, I suppose.

tboeckel commented 8 years ago

Originally on 2014-11-09 22:32:18 +0100

Then we have to wait until you get such a bad mail again or hope that the crash never happens again.

I will leave this ticket open until then.

jens-maus commented 8 years ago

Originally by pferrucci@sfr.fr on 2014-11-11 11:13:50 +0100

I think you can close it. It's working well.

While I was testing Final Edition, I probably booted the system with a configuration that caused this (probably the fact that I installed biosversion.resource.kmod that shouldn't be used).

tboeckel commented 8 years ago

Originally on 2014-11-11 11:17:08 +0100

As you like. The ticket will nevertheless continue to exist, so it can be reopened later if the issue arises again.

jens-maus commented 8 years ago

Originally by pferrucci@sfr.fr on 2015-07-09 16:36:46 +0200

Well it's back now with version from 19 June. Attaching a new debug log.

jens-maus commented 8 years ago

Originally by pferrucci@sfr.fr on 2015-07-09 16:37:16 +0200

Attachment added: yam-2015-06-19.txt (10.1 KiB)

jens-maus commented 8 years ago

Originally by pferrucci@sfr.fr on 2015-07-09 16:53:35 +0200

This log was with files: Muimaster 20.6373 (but it crashes also with 20.6421) Frimagedisplay.mui 20.315 (I'm surprised to see it mentioned in the 68k registers) Intuition 54.19 (crashes also with 54.18 )

Should I try with different version os intuition? Can you add more debug output at some "interesting" locations? :-)

tboeckel commented 8 years ago

Originally on 2015-07-10 09:29:36 +0200

I think I found a possible reason for the crash. The scrollbars are added in an asynchronous fashion to avoid certain other issued. However, if there are no mails to be transferred (as indicated by your log) it might happen that the NListview object is destroyed before the asynchonous method to add the scrollbars is actually executed. When the method is finally executed it is executed on a dead object and most probably causes the crash you are seeing.

I added a fix to NListview.mcc which removes any asynchronous pushed method in case the object is destroyed before the method has been handled. Please try this hopefully fixed version.

tboeckel commented 8 years ago

Originally on 2015-07-10 09:30:26 +0200

Attachment added: NListview_os4.lha (101.9 KiB) NListview.mcc for AmigaOS4 with unpushing asynchronous methods

tboeckel commented 8 years ago

Originally on 2015-07-10 09:30:44 +0200

Attachment added: NListview_os3.lha (67.4 KiB) NListview.mcc for AmigaOS3 with unpushing asynchronous methods

jens-maus commented 8 years ago

Originally by pferrucci@sfr.fr on 2015-07-10 15:56:23 +0200

Thanks. Unfortunately I did a wrong move and I deleted all my spam emails so I don't have a lot of emails in my mail accounts to check with.

Anyway I tried the OS4 NListview.mcc and I don't have the crash. Let me check these coming days and I'll tell you soon.

Thanks again.

jens-maus commented 8 years ago

Originally by pferrucci@sfr.fr on 2015-07-12 16:04:47 +0200

I think it's fixed. I couldn't make it crash. Thanks a lot.

tboeckel commented 8 years ago

Originally on 2015-07-12 20:10:36 +0200

Ok, but please keep an eye on this issue in case it should happen again.