jens-maus / yam

:mailbox_with_mail: YAM (short for 'Yet Another Mailer') is a MIME-compliant open-source Internet email client written for Amiga-based computer systems (AmigaOS4, AmigaOS3, MorphOS, AROS). It supports POP3, SMTP, TLSv1/SSLv3 connection security, multiple users, multiple identities, PGPv2/v5 encryption, unlimited hierarchical folders, an ARexx interface, etc...

https://yam.ch

GNU General Public License v2.0

62 stars 18 forks source link

Use the new title class instead of "old" register class #607

Closed jens-maus closed 8 years ago

jens-maus commented 8 years ago

Originally by javierdlr@euskalnet.net on 2015-08-25 00:06:51 +0200

Problem

Can at least for AOS4 the new title class be sued insetad of "old" register class?

Analysis

Files affected: TCPIPConfigPage.c, LookFeelConfigPage.c, IdentitiesConfigPage.c, FiltersConfigPage.c and WriteWindow.c (hope they are all)

Enhancement recommendation

Example for TCPIPConfigPage.c: ..

if define(amigaos4)

MUIA_ConfigPage_Contents, VGroup,
  Child, TitleObject,
    Child, TextObject, MUIA_Text_Contents,rtitles[0], End,
    Child, TextObject, MUIA_Text_Contents,rtitles[1], End,
  End,

else

MUIA_ConfigPage_Contents, RegisterGroup(rtitles),
  MUIA_CycleChain, TRUE,

endif

tboeckel commented 8 years ago

Originally on 2015-08-25 08:27:55 +0200

Same question as for MUI ticket 241: why? What advantage would such a change bring to you?

jens-maus commented 8 years ago

Originally by javierdlr@euskalnet.net on 2015-08-25 22:35:57 +0200

As I have under MUI (prefs) Groups Stretching set to 0% those tabs look "ugly"/unfriendly/.. under AOS4+MUI4.

Instead a '#if define (amigaos4)' it would be better check for 'mui_lib' version in use and the stick with "old" register class (MUI3) or use new title class (MUI4).

tboeckel commented 8 years ago

Originally on 2015-09-23 09:07:15 +0200

This issue has been fixed in MUI. See MUI ticket 241 for details: https://muidev.de/ticket/241