jens1o / vscode-smarty

Smarty syntax highlight extension for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=imperez.smarty
GNU General Public License v3.0
14 stars 9 forks source link

feature request : Create a language server to handle multiple templates #16

Open nn-hh opened 6 years ago

nn-hh commented 6 years ago

php developers handle not only Smarty but also many templates. Smarty,Twig,Blade...etc Is it possible to handle more than one? Smarty: File : .tpl range : {} Twig: File : .twig range : {% %}

Especially the two are very similar Currently, there is no extended function handling multiple templates. Also weak because it does not have a language server.

jens1o commented 6 years ago

Personally I think twig is a bad example. https://marketplace.visualstudio.com/search?term=twig&target=VSCode&category=All%20categories&sortBy=Relevance

There are many many extensions serving this purpose. It would also mean that we have a lot more of components to maintain.

Personally, I use twig very rarely, but I'm open for other thoughts, reasons and examples.

nn-hh commented 6 years ago

Thank you for listening. sorry, I am not good at English and I can not convey it well.

Reason why I thought of multiple templates: I think highlights and snippets are important for this type of extension. and html intellisense to work. However, other than that is not important.

Create a language server...It understands html and the range of templates. I thought that if change the range can handle several templat. twig is just an example.It is not a fan of twig. I just used it two or three times.

Demand is too little with smarty alone. There is no pull request unless there is some user. It is hard to maintain. In fact, the Predecessor abandoned it. My most fearful thing is that your motivation will go down.

Is there no extension for multiple templates? I thought. and It is enough to install one. Is there a user who wants it? I thought. There are not so many templates for php. Also, once you make it, After that, just update the snippet. It is my simple and shallow idea.

Sorry for the long sentences. and I am sorry that my English is not good

jens1o commented 6 years ago

sorry, I am not good at English and I can not convey it well. Sorry for the long sentences. and I am sorry that my English is not good

That's absolutely fine, no worries. :) I'm not a native English speaker either.

There is no pull request unless there is some user. It is hard to maintain. In fact, the Predecessor abandoned it.

Well, in fact I want to improve my knowledge in parsing ASTs(and provide intellisense-support based on that). I'm not dependent on any pull requests, while it's still awesome that people want to improve this extension even more. (Read: Contributions welcome!) Personally, I think a smaller user base is perfectly fine to make some experiments. :) The predecessor did not abandoned it, as he stated multiple times, he just lacked of time and well, yes, perhaps he was a little bit unmotivated or could not support it further.

and It is enough to install one. Is there a user who wants it? I thought.

Perhaps we can do this as soon as Smarty is stable enough for me. Once it's stable, I'm going to rethink about it, but first, let's provide awesome Smarty support and then expand on multiple template engines. :)

My most fearful thing is that your motivation will go down.

I'm confident enough to still maintain it as good as possible in the future, it's my passion to make and support Open-Source Software projects. :) At the moment, I'm "only" missing the time to do it. :)

Thanks for your thoughts. I really appreciate it. :)

nn-hh commented 6 years ago

Thank you! I am very satisfied with the answer. This time, I brought a plan with mind about the number of users and your motivation. I do not mind even if the answer of the multiple template engines later is NO. Please make a good product at your pace.

FDiskas commented 1 year ago

Working example https://github.com/ssigwart/vscode-smarty