search

jensarps / AMD-feature

A loader plugin for AMD loaders
Other
161 stars 10 forks source link

Wrap "impl" into an array in build require call #11

Closed lbernau closed 10 years ago

lbernau commented 10 years ago

Require call was different between "build" and "runtime" evaluation: During runtime the implementation was wrapped into an array, during build it was not. Using the same implementation map for both cases did not work.

jensarps commented 10 years ago

Ohhhh, crap… thanks for finding this and reporting!

I did some extensive testing and didn't find any issues – but I only tested "manually". Well, this is exactly the type of issue that proves one needs to write real tests, no matter how small the code is. I'll put this on my list.

Will merge this asap and create a new tag.

jensarps commented 10 years ago

Available in 1.2.1