jensarps / AMD-feature

A loader plugin for AMD loaders
Other
161 stars 10 forks source link

A typo in README.md #12

Closed gamtiq closed 10 years ago

gamtiq commented 10 years ago

There is a typo in README.md inside Direct Loading section (actually it originates from my pull request). Insead of

The name of the feature will be passed as parameter into the implementation() function.

should be

The name of the feature will be passed as parameter into the module() function.

Also I suppose that is better changing part of the example inside the section from

isAvailable: function(){
      // This is the fallback
      return true;
},

to

// This is the fallback
isAvailable: true,
jensarps commented 10 years ago

Good catch, thanks for pointing out!

gamtiq commented 10 years ago

You've made a misprint when changing the example. Instead of

isAvailable: return true;

should be

isAvailable: true,
jensarps commented 10 years ago

Argh, thanks, fixed.